From: Christoph Hellwig <hch@lst.de>
To: linux-xfs@vger.kernel.org
Cc: david@fromorbit.com
Subject: xfs: clean up log tickets and record writes v4
Date: Wed, 25 Mar 2020 19:42:57 +0100 [thread overview]
Message-ID: <20200325184305.1361872-1-hch@lst.de> (raw)
This series follows up on conversions about relogging infrastructure
and the way xfs_log_done() does two things but only one of several
callers uses both of those functions. It also pointed out that
xfs_trans_commit() never writes to the log anymore, so only
checkpoints pass a ticket to xlog_write() with this flag set and
no transaction makes multiple calls to xlog_write() calls on the
same ticket. Hence there's no real need for XLOG_TIC_INITED to track
whether a ticket has written a start record to the log anymore.
A lot of further cleanups fell out of this. Once we no longer use
XLOG_TIC_INITED to carry state inside the write loop, the logic
can be simplified in both xlog_write and xfs_log_done. xfs_log_done
can be split up, and then the call chain can be flattened because
xlog_write_done() and xlog_commit_record() are basically the same.
This then leads to cleanups writing both commit and unmount records.
Finally, to complete what started all this, the XLOG_TIC_INITED flag
is removed.
A git tree is avaiblable here:
git://git.infradead.org/users/hch/xfs.git xlog-ticket-cleanup.4
Gitweb:
http://git.infradead.org/users/hch/xfs.git/shortlog/refs/heads/xlog-ticket-cleanup.4
Changes since v3:
- pass an explicit need_start_rec to xlog_write()
- rename xlog_ticket_done to xfs_log_ticket_ungrant and
xlog_ticket_regrant to xfs_log_ticket_regrant
- rename xlog_write_done to xlog_commit_record
Changes since v2:
- fix a commit message typo
- move the XLOG_TIC_INITED earlier, and move another hunk to this patch
- keep checking for XLOG_FORCED_SHUTDOWN and skip regrants
- merge the two patches for refactoring and renaming the log unmount
record handling
Changes since v1:
- taking this over from Dave (for now) as he is still injured, an it
interacts closely with my log error handling bits
- rebased on top of for-next + the "more log cleanups" series
- fix an accounting error in xlog_write
- use a bool for the ticket header in xlog_write
- add a new patch to split xlog_ticket_done
next reply other threads:[~2020-03-25 18:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 18:42 Christoph Hellwig [this message]
2020-03-25 18:42 ` [PATCH 1/8] xfs: don't try to write a start record into every iclog Christoph Hellwig
2020-03-26 4:49 ` Darrick J. Wong
2020-03-26 11:09 ` Brian Foster
2020-03-25 18:42 ` [PATCH 2/8] xfs: re-order initial space accounting checks in xlog_write Christoph Hellwig
2020-03-25 18:43 ` [PATCH 3/8] xfs: refactor and split xfs_log_done() Christoph Hellwig
2020-03-25 18:43 ` [PATCH 4/8] xfs: kill XLOG_TIC_INITED Christoph Hellwig
2020-03-25 18:43 ` [PATCH 5/8] xfs: split xlog_ticket_done Christoph Hellwig
2020-03-25 18:43 ` [PATCH 6/8] xfs: merge xlog_commit_record with xlog_write_done Christoph Hellwig
2020-03-25 18:43 ` [PATCH 7/8] xfs: refactor unmount record writing Christoph Hellwig
2020-03-25 18:43 ` [PATCH 8/8] xfs: remove some stale comments from the log code Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325184305.1361872-1-hch@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).