Linux-XFS Archive on
 help / color / Atom feed
From: Christoph Hellwig <>
	Kaixu Xia <>
Subject: Re: [PATCH] xfs: remove unnecessary judgment from xfs_create
Date: Fri, 27 Mar 2020 02:04:16 -0700
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Mar 27, 2020 at 01:45:56PM +0800, wrote:
> From: Kaixu Xia <>
> Since the "no-allocation" reservations for file creations has
> been removed, the resblks value should be larger than zero, so
> remove unnecessary judgment.

The patch looks good:

Reviewed-by: Christoph Hellwig <>

Although I would replace "judgement" with "condition" in the commit

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  5:45 xiakaixu1987
2020-03-27  9:04 ` Christoph Hellwig [this message]
2020-03-27 15:45 ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-XFS Archive on

Archives are clonable:
	git clone --mirror linux-xfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-xfs linux-xfs/ \
	public-inbox-index linux-xfs

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone