From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 0/2] xfs: a couple AIL pushing trylock fixes
Date: Fri, 27 Mar 2020 12:44:12 -0400 [thread overview]
Message-ID: <20200327164412.GA29156@bfoster> (raw)
In-Reply-To: <20200327153205.GH29339@magnolia>
On Fri, Mar 27, 2020 at 08:32:05AM -0700, Darrick J. Wong wrote:
> On Thu, Mar 26, 2020 at 09:17:01AM -0400, Brian Foster wrote:
> > Hi all,
> >
> > Here's a couple more small fixes that fell out of the auto relog work.
> > The dquot issue is actually a deadlock vector if we randomly relog dquot
> > buffers (which is only done for test purposes), but I figure we should
> > handle dquot buffers similar to how inode buffers are handled. Thoughts,
> > reviews, flames appreciated.
>
> Oops, I missed this one, will review now...
>
> Do you think there needs to be an explicit testcase for this? Or are
> the current generic/{388,475} good enough? I'm pretty sure I've seen
> this exact deadlock on them every now and again, so we're probably
> covered.
>
I'm actually not aware of a related upstream deadlock. That doesn't mean
there isn't one of course, but the problem I hit was related to the
random buffer relogging stuff in the auto relog series. I split these
out because xfsaild is intended to be mostly async, so they seemed like a
generic fixups..
Brian
> --D
>
>
> > Brian
> >
> > Brian Foster (2):
> > xfs: trylock underlying buffer on dquot flush
> > xfs: return locked status of inode buffer on xfsaild push
> >
> > fs/xfs/xfs_dquot.c | 6 +++---
> > fs/xfs/xfs_dquot_item.c | 3 ++-
> > fs/xfs/xfs_inode_item.c | 3 ++-
> > fs/xfs/xfs_qm.c | 14 +++++++++-----
> > 4 files changed, 16 insertions(+), 10 deletions(-)
> >
> > --
> > 2.21.1
> >
>
next prev parent reply other threads:[~2020-03-27 16:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 13:17 [PATCH 0/2] xfs: a couple AIL pushing trylock fixes Brian Foster
2020-03-26 13:17 ` [PATCH 1/2] xfs: trylock underlying buffer on dquot flush Brian Foster
2020-03-27 12:59 ` Christoph Hellwig
2020-03-27 15:45 ` Darrick J. Wong
2020-03-27 16:44 ` Brian Foster
2020-03-27 16:46 ` Brian Foster
2020-03-27 17:04 ` Darrick J. Wong
2020-03-27 16:50 ` Darrick J. Wong
2020-03-29 22:46 ` Dave Chinner
2020-03-29 23:01 ` Dave Chinner
2020-03-30 12:15 ` Brian Foster
2020-03-31 0:04 ` Dave Chinner
2020-03-31 11:46 ` Brian Foster
2020-03-26 13:17 ` [PATCH 2/2] xfs: return locked status of inode buffer on xfsaild push Brian Foster
2020-03-27 13:00 ` Christoph Hellwig
2020-03-27 15:39 ` Darrick J. Wong
2020-03-27 15:32 ` [PATCH 0/2] xfs: a couple AIL pushing trylock fixes Darrick J. Wong
2020-03-27 16:44 ` Brian Foster [this message]
2020-03-29 16:43 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327164412.GA29156@bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).