From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2 V2] xfs: gut error handling in xfs_trans_unreserve_and_mod_sb()
Date: Wed, 20 May 2020 13:27:02 -0700 [thread overview]
Message-ID: <20200520202702.GA17627@magnolia> (raw)
In-Reply-To: <20200520074805.GA21299@infradead.org>
On Wed, May 20, 2020 at 12:48:05AM -0700, Christoph Hellwig wrote:
> On Wed, May 20, 2020 at 05:33:58PM +1000, Dave Chinner wrote:
> > + /*
> > + * Debug checks outside of the spinlock so they don't lock up the
> > + * machine if they fail.
> > + */
> > + ASSERT(mp->m_sb.sb_frextents >= 0);
> > + ASSERT(mp->m_sb.sb_dblocks >= 0);
> > + ASSERT(mp->m_sb.sb_agcount >= 0);
> > + ASSERT(mp->m_sb.sb_imax_pct >= 0);
> > + ASSERT(mp->m_sb.sb_rextsize >= 0);
> > + ASSERT(mp->m_sb.sb_rbmblocks >= 0);
> > + ASSERT(mp->m_sb.sb_rblocks >= 0);
> > + ASSERT(mp->m_sb.sb_rextents >= 0);
> > + ASSERT(mp->m_sb.sb_rextslog >= 0);
Except for imax_pct and rextslog, all of these are unsigned quantities,
right? So the asserts will /never/ trigger?
--D
> > return;
>
> No need for the return here at the end of the function.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-05-20 20:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 21:48 [PATCH 0/2] xfs: fix unecessary percpu counter overhead Dave Chinner
2020-05-19 21:48 ` [PATCH 1/2] xfs: gut error handling in xfs_trans_unreserve_and_mod_sb() Dave Chinner
2020-05-20 6:53 ` Christoph Hellwig
2020-05-20 7:03 ` Dave Chinner
2020-05-20 7:33 ` [PATCH 1/2 V2] " Dave Chinner
2020-05-20 7:48 ` Christoph Hellwig
2020-05-20 20:27 ` Darrick J. Wong [this message]
2020-05-20 21:55 ` Dave Chinner
2020-05-20 22:28 ` Darrick J. Wong
2020-05-20 22:37 ` Dave Chinner
2020-05-19 21:48 ` [PATCH 2/2] xfs: reduce free inode accounting overhead Dave Chinner
2020-05-20 6:56 ` Christoph Hellwig
2020-05-20 20:43 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520202702.GA17627@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).