From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A15C433DF for ; Fri, 22 May 2020 06:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D060E20757 for ; Fri, 22 May 2020 06:37:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728031AbgEVGh0 (ORCPT ); Fri, 22 May 2020 02:37:26 -0400 Received: from verein.lst.de ([213.95.11.211]:57894 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728012AbgEVGh0 (ORCPT ); Fri, 22 May 2020 02:37:26 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 614AC68C4E; Fri, 22 May 2020 08:37:24 +0200 (CEST) Date: Fri, 22 May 2020 08:37:24 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, hch@lst.de Subject: Re: [PATCH 05/12] xfs: remove flags argument from xfs_inode_ag_walk Message-ID: <20200522063724.GA2445@lst.de> References: <159011600616.77079.14748275956667624732.stgit@magnolia> <159011603978.77079.10531037194098683108.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159011603978.77079.10531037194098683108.stgit@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, May 21, 2020 at 07:53:59PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > The incore inode walk code passes a flags argument and a pointer from > the xfs_inode_ag_iterator caller all the way to the iteration function. > We can reduce the function complexity by passing flags through the > private pointer. > > Signed-off-by: Darrick J. Wong Looks good, Reviewed-by: Christoph Hellwig