From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Kees Cook <keescook@chromium.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: Replace one-element arrays with flexible-array members
Date: Mon, 25 May 2020 09:23:15 +1000 [thread overview]
Message-ID: <20200524232315.GQ2040@dread.disaster.area> (raw)
In-Reply-To: <20200524022555.GA252930@magnolia>
On Sat, May 23, 2020 at 07:25:55PM -0700, Darrick J. Wong wrote:
> Please always cc linux-xfs when you're changing fs/xfs code.
>
> *Especially* when it involves changes to ondisk structures.
I can't find this patch in lkml or -fsdevel on lore.kernel.org, so I
have no idea where this patch even came from. Which means I can't
even check what the structure change is because it wasn't quoted in
full.
So, NACK on this until the entire patch is resent to linux-xfs and
run through all the shutdown and error recovery tests in fstests....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-05-24 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200522215542.GA18898@embeddedor>
[not found] ` <202005221606.A1647A0@keescook>
[not found] ` <20200523202149.GI29907@embeddedor>
2020-05-24 2:25 ` [PATCH] xfs: Replace one-element arrays with flexible-array members Darrick J. Wong
2020-05-24 23:23 ` Dave Chinner [this message]
2020-05-25 18:41 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524232315.GQ2040@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).