From: Dave Chinner <david@fromorbit.com>
To: Joe Perches <joe@perches.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: Use fallthrough pseudo-keyword
Date: Wed, 8 Jul 2020 16:55:12 +1000 [thread overview]
Message-ID: <20200708065512.GN2005@dread.disaster.area> (raw)
In-Reply-To: <96f58df8a489093fb239cea8d36768b921269056.camel@perches.com>
On Tue, Jul 07, 2020 at 06:48:29PM -0700, Joe Perches wrote:
> On Tue, 2020-07-07 at 13:50 -0700, Darrick J. Wong wrote:
> > On Tue, Jul 07, 2020 at 03:05:04PM -0500, Gustavo A. R. Silva wrote:
> > > Replace the existing /* fall through */ comments and its variants with
> > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> > > fall-through markings when it is the case.
> []
> > I don't get it, what's the point? Are gcc/clang
> > refusing to support -Wimplicit-fallthrough=[1-4] past a certain date?
>
> clang doesn't support comments
So fix the damn compiler.
-Dave
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2020-07-08 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 20:05 [PATCH] xfs: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-07 20:50 ` Darrick J. Wong
2020-07-08 1:48 ` Joe Perches
2020-07-08 6:55 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708065512.GN2005@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=gustavoars@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).