Linux-XFS Archive on lore.kernel.org
 help / color / Atom feed
* [xfs-linux:xfs-5.9-merge 112/116] fs/xfs/libxfs/xfs_attr.c:1181:27: warning: variable 'blk' set but not used
@ 2020-07-25  1:43 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-07-25  1:43 UTC (permalink / raw)
  To: Allison Collins
  Cc: kbuild-all, linux-xfs, Darrick J. Wong, Brian Foster, Chandan Rajendra


[-- Attachment #1: Type: text/plain, Size: 2026 bytes --]

tree:   https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git xfs-5.9-merge
head:   9f347d7a7e0ee9b12434b9ef0ccac3a2680960de
commit: 534c7e150352361b2660ee3ea87ce91d3138d74d [112/116] xfs: Add helper function xfs_attr_node_removename_setup
config: x86_64-rhel-7.6-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        git checkout 534c7e150352361b2660ee3ea87ce91d3138d74d
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/xfs/libxfs/xfs_attr.c: In function 'xfs_attr_node_removename_setup':
>> fs/xfs/libxfs/xfs_attr.c:1181:27: warning: variable 'blk' set but not used [-Wunused-but-set-variable]
    1181 |  struct xfs_da_state_blk *blk;
         |                           ^~~

vim +/blk +1181 fs/xfs/libxfs/xfs_attr.c

  1169	
  1170	/*
  1171	 * Initial setup for xfs_attr_node_removename.  Make sure the attr is there and
  1172	 * the blocks are valid.  Attr keys with remote blocks will be marked
  1173	 * incomplete.
  1174	 */
  1175	STATIC
  1176	int xfs_attr_node_removename_setup(
  1177		struct xfs_da_args	*args,
  1178		struct xfs_da_state	**state)
  1179	{
  1180		int			error;
> 1181		struct xfs_da_state_blk	*blk;
  1182	
  1183		error = xfs_attr_node_hasname(args, state);
  1184		if (error != -EEXIST)
  1185			return error;
  1186	
  1187		blk = &(*state)->path.blk[(*state)->path.active - 1];
  1188		ASSERT(blk->bp != NULL);
  1189		ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
  1190	
  1191		if (args->rmtblkno > 0) {
  1192			error = xfs_attr_leaf_mark_incomplete(args, *state);
  1193			if (error)
  1194				return error;
  1195	
  1196			return xfs_attr_rmtval_invalidate(args);
  1197		}
  1198	
  1199		return 0;
  1200	}
  1201	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50005 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-25  1:43 [xfs-linux:xfs-5.9-merge 112/116] fs/xfs/libxfs/xfs_attr.c:1181:27: warning: variable 'blk' set but not used kernel test robot

Linux-XFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-xfs/0 linux-xfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-xfs linux-xfs/ https://lore.kernel.org/linux-xfs \
		linux-xfs@vger.kernel.org
	public-inbox-index linux-xfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-xfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git