From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [RFC 0/2] Avoid indirect function calls in iomap
Date: Tue, 28 Jul 2020 18:32:13 +0100 [thread overview]
Message-ID: <20200728173216.7184-1-willy@infradead.org> (raw)
This RFC converts indirect function calls into direct function calls.
It converts one user as an example (readahead). Converting more users of
iomap_apply() would yield a more advantageous diffstat. It's actually
slightly more code in each filesystem, but indirect function calls
are pretty expensive. It also flattens the call graph (see the patch
2 changelog). This all needs more refinement, but I'm about to start
work on overhauling the block size < page size support, and I thought
I'd send this out now.
It does survive a basic xfstests run.
Matthew Wilcox (Oracle) (2):
iomap: Add iomap_iter
iomap: Convert readahead to iomap_iter
fs/iomap/apply.c | 29 +++++++++++++++
fs/iomap/buffered-io.c | 82 ++++++++++++++----------------------------
fs/xfs/xfs_aops.c | 9 ++++-
fs/xfs/xfs_iomap.c | 15 ++++++++
fs/xfs/xfs_iomap.h | 2 ++
fs/zonefs/super.c | 20 ++++++++++-
include/linux/iomap.h | 67 +++++++++++++++++++++++++++++++++-
7 files changed, 165 insertions(+), 59 deletions(-)
--
2.27.0
next reply other threads:[~2020-07-28 17:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 17:32 Matthew Wilcox (Oracle) [this message]
2020-07-28 17:32 ` [PATCH 1/2] iomap: Add iomap_iter Matthew Wilcox (Oracle)
2020-08-11 21:01 ` Darrick J. Wong
2020-08-11 21:32 ` Matthew Wilcox
2020-07-28 17:32 ` [PATCH 2/2] iomap: Convert readahead to iomap_iter Matthew Wilcox (Oracle)
2020-08-11 20:56 ` Darrick J. Wong
2020-08-11 22:31 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728173216.7184-1-willy@infradead.org \
--to=willy@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).