From: Christoph Hellwig <hch@infradead.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Brian Foster <bfoster@redhat.com>,
fstests <fstests@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH 1/4] generic: require discard zero behavior for dmlogwrites on XFS
Date: Thu, 27 Aug 2020 08:37:00 +0100 [thread overview]
Message-ID: <20200827073700.GA30374@infradead.org> (raw)
In-Reply-To: <CAOQ4uxhhN6Gj9AZBvEHUDLjTRKWi7=rOhitmbDLWFA=dCZQxXw@mail.gmail.com>
On Thu, Aug 27, 2020 at 10:29:05AM +0300, Amir Goldstein wrote:
> I figured you'd say something like that :)
> but since we are talking about dm-thin as a solution for predictable
> behavior at the moment and this sanity check helps avoiding adding
> new tests that can fail to some extent, is the proposed bandaid good enough
> to keep those tests alive until a better solution is proposed?
Well, the problem is that a test that wants to reliable nuke data needs
to... *drumroll* reliably nuke data. Which means zeroing or at least
a known pattern. discard doesn't give you that.
I don't see how a plain discard is going to work for any file system
for that particular case.
next prev parent reply other threads:[~2020-08-27 7:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 14:38 [PATCH 0/4] fix up generic dmlogwrites tests to work with XFS Brian Foster
2020-08-26 14:38 ` [PATCH 1/4] generic: require discard zero behavior for dmlogwrites on XFS Brian Foster
2020-08-27 6:58 ` Amir Goldstein
2020-08-27 7:02 ` Christoph Hellwig
2020-08-27 7:29 ` Amir Goldstein
2020-08-27 7:37 ` Christoph Hellwig [this message]
2020-08-27 15:57 ` Josef Bacik
2020-08-27 17:02 ` Christoph Hellwig
2020-08-27 18:35 ` Brian Foster
2020-08-29 6:46 ` Christoph Hellwig
2020-08-30 13:30 ` Amir Goldstein
2020-08-31 13:37 ` Brian Foster
2020-08-29 6:44 ` Christoph Hellwig
2020-08-27 14:11 ` Brian Foster
[not found] ` <CAOQ4uxj6RKX01kKKc_SGZJegWEKaF+D8ZNJGALvh4o0c5bBcBg@mail.gmail.com>
2020-08-28 14:10 ` Brian Foster
2020-08-27 7:38 ` Christoph Hellwig
2020-08-26 14:38 ` [PATCH 2/4] generic/455: use thin volume for dmlogwrites target device Brian Foster
2020-08-26 14:38 ` [PATCH 3/4] generic/457: " Brian Foster
2020-08-26 14:38 ` [PATCH 4/4] generic/470: " Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827073700.GA30374@infradead.org \
--to=hch@infradead.org \
--cc=amir73il@gmail.com \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).