From: Qian Cai <cai@lca.pw>
To: darrick.wong@oracle.com
Cc: hch@infradead.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Qian Cai <cai@lca.pw>
Subject: [PATCH v2] iomap: Fix WARN_ON_ONCE() from unprivileged users
Date: Sun, 30 Aug 2020 21:45:11 -0400 [thread overview]
Message-ID: <20200831014511.17174-1-cai@lca.pw> (raw)
It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by
unprivileged users which would taint the kernel, or worse - panic if
panic_on_warn or panic_on_taint is set. Hence, just convert it to
pr_warn_ratelimited() to let users know their workloads are racing.
Thanks Dave Chinner for the initial analysis of the racing reproducers.
Signed-off-by: Qian Cai <cai@lca.pw>
---
v2: Record the path, pid and command as well.
fs/iomap/direct-io.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index c1aafb2ab990..66a4502ef675 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -374,6 +374,7 @@ iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length,
void *data, struct iomap *iomap, struct iomap *srcmap)
{
struct iomap_dio *dio = data;
+ char pathname[128], *path;
switch (iomap->type) {
case IOMAP_HOLE:
@@ -389,7 +390,21 @@ iomap_dio_actor(struct inode *inode, loff_t pos, loff_t length,
case IOMAP_INLINE:
return iomap_dio_inline_actor(inode, pos, length, dio, iomap);
default:
- WARN_ON_ONCE(1);
+ /*
+ * DIO is not serialised against mmap() access at all, and so
+ * if the page_mkwrite occurs between the writeback and the
+ * iomap_apply() call in the DIO path, then it will see the
+ * DELALLOC block that the page-mkwrite allocated.
+ */
+ path = file_path(dio->iocb->ki_filp, pathname,
+ sizeof(pathname));
+ if (IS_ERR(path))
+ path = "(unknown)";
+
+ pr_warn_ratelimited("page_mkwrite() is racing with DIO read (iomap->type = %u).\n"
+ "File: %s PID: %d Comm: %.20s\n",
+ iomap->type, path, current->pid,
+ current->comm);
return -EIO;
}
}
--
2.18.4
next reply other threads:[~2020-08-31 1:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 1:45 Qian Cai [this message]
2020-08-31 15:48 ` [PATCH v2] iomap: Fix WARN_ON_ONCE() from unprivileged users Eric Sandeen
2020-08-31 15:56 ` Darrick J. Wong
2020-08-31 16:13 ` Eric Sandeen
2020-08-31 16:01 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831014511.17174-1-cai@lca.pw \
--to=cai@lca.pw \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).