From: Brian Foster <bfoster@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/5] xfs: use the finobt block counts to speed up mount times
Date: Mon, 31 Aug 2020 15:06:45 -0400 [thread overview]
Message-ID: <20200831190645.GD12035@bfoster> (raw)
In-Reply-To: <159858220352.3058056.14870764546265114620.stgit@magnolia>
On Thu, Aug 27, 2020 at 07:36:43PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Now that we have reliable finobt block counts, use them to speed up the
> per-AG block reservation calculations at mount time.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/libxfs/xfs_ialloc_btree.c | 28 +++++++++++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
>
>
> diff --git a/fs/xfs/libxfs/xfs_ialloc_btree.c b/fs/xfs/libxfs/xfs_ialloc_btree.c
> index ee9d407ab9da..a5461091ba7b 100644
> --- a/fs/xfs/libxfs/xfs_ialloc_btree.c
> +++ b/fs/xfs/libxfs/xfs_ialloc_btree.c
> @@ -694,6 +694,28 @@ xfs_inobt_count_blocks(
> return error;
> }
>
> +/* Read finobt block count from AGI header. */
> +static int
> +xfs_finobt_read_blocks(
> + struct xfs_mount *mp,
> + struct xfs_trans *tp,
> + xfs_agnumber_t agno,
> + xfs_extlen_t *tree_blocks)
> +{
> + struct xfs_buf *agbp;
> + struct xfs_agi *agi;
> + int error;
> +
> + error = xfs_ialloc_read_agi(mp, tp, agno, &agbp);
> + if (error)
> + return error;
> +
> + agi = agbp->b_addr;
> + *tree_blocks = be32_to_cpu(agi->agi_fblocks);
> + xfs_trans_brelse(tp, agbp);
> + return 0;
> +}
> +
> /*
> * Figure out how many blocks to reserve and how many are used by this btree.
> */
> @@ -711,7 +733,11 @@ xfs_finobt_calc_reserves(
> if (!xfs_sb_version_hasfinobt(&mp->m_sb))
> return 0;
>
> - error = xfs_inobt_count_blocks(mp, tp, agno, XFS_BTNUM_FINO, &tree_len);
> + if (xfs_sb_version_hasinobtcounts(&mp->m_sb))
> + error = xfs_finobt_read_blocks(mp, tp, agno, &tree_len);
> + else
> + error = xfs_inobt_count_blocks(mp, tp, agno, XFS_BTNUM_FINO,
> + &tree_len);
> if (error)
> return error;
>
>
next prev parent reply other threads:[~2020-08-31 19:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 2:36 [PATCH v3 0/5] xfs: add inode btree blocks counters to the AGI header Darrick J. Wong
2020-08-28 2:36 ` [PATCH 1/5] xfs: store inode btree block counts in " Darrick J. Wong
2020-08-31 19:06 ` Brian Foster
2020-08-31 19:40 ` Darrick J. Wong
2020-08-28 2:36 ` [PATCH 2/5] xfs: use the finobt block counts to speed up mount times Darrick J. Wong
2020-08-31 19:06 ` Brian Foster [this message]
2020-08-28 2:36 ` [PATCH 3/5] xfs: support inode btree blockcounts in online scrub Darrick J. Wong
2020-08-31 19:06 ` Brian Foster
2020-08-28 2:36 ` [PATCH 4/5] xfs: support inode btree blockcounts in online repair Darrick J. Wong
2020-08-31 19:07 ` Brian Foster
2020-08-31 19:40 ` Darrick J. Wong
2020-08-28 2:37 ` [PATCH 5/5] xfs: enable new inode btree counters feature Darrick J. Wong
2020-08-31 19:07 ` Brian Foster
2020-09-02 2:55 [PATCH v4 0/5] xfs: add inode btree blocks counters to the AGI header Darrick J. Wong
2020-09-02 2:56 ` [PATCH 2/5] xfs: use the finobt block counts to speed up mount times Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831190645.GD12035@bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).