From: Brian Foster <bfoster@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 0/2] iomap: avoid soft lockup warnings on large ioends
Date: Fri, 2 Oct 2020 11:33:55 -0400 [thread overview]
Message-ID: <20201002153357.56409-1-bfoster@redhat.com> (raw)
Hi all,
My understanding is that there's still no real agreement on the proper
approach to address this problem. The RFC I floated [1] intended to cap
the size of ioends to avoid any latency issues with holding so many
pages in writeback for effectively a single completion instance of a GB+
sized I/O. Instead, Christoph preferred to dump those large bios onto
the completion workqueue and use cond_resched() rather than cap the
ioend size. This series implements the latter (for XFS) since it seems
like incremental progress and should at least address the warning.
Thoughts, reviews, flames appreciated.
Brian
[1] https://lore.kernel.org/linux-fsdevel/20200825144917.GA321765@bfoster/
Brian Foster (2):
iomap: resched ioend completion when in non-atomic context
xfs: kick extra large ioends to completion workqueue
fs/iomap/buffered-io.c | 15 +++++++++------
fs/xfs/xfs_aops.c | 12 ++++++++++--
include/linux/iomap.h | 2 +-
3 files changed, 20 insertions(+), 9 deletions(-)
--
2.25.4
next reply other threads:[~2020-10-02 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 15:33 Brian Foster [this message]
2020-10-02 15:33 ` [PATCH 1/2] iomap: resched ioend completion when in non-atomic context Brian Foster
2020-10-02 15:33 ` [PATCH 2/2] xfs: kick extra large ioends to completion workqueue Brian Foster
2020-10-02 16:19 ` Darrick J. Wong
2020-10-02 16:38 ` Brian Foster
2020-10-03 0:26 ` kernel test robot
2020-10-05 15:21 ` [PATCH v2 " Brian Foster
2020-10-06 3:55 ` Darrick J. Wong
2020-10-06 12:44 ` Brian Foster
2021-05-06 19:31 ` Darrick J. Wong
2021-05-07 14:06 ` Brian Foster
2021-05-07 14:40 ` Matthew Wilcox
2021-05-10 2:45 ` Dave Chinner
2020-10-06 14:07 ` Matthew Wilcox
2021-05-06 19:34 ` Darrick J. Wong
2021-05-06 19:45 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002153357.56409-1-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).