From: Gao Xiang <hsiangkao@aol.com>
To: linux-xfs <linux-xfs@vger.kernel.org>
Cc: Eric Sandeen <sandeen@redhat.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Dave Chinner <david@fromorbit.com>,
Gao Xiang <hsiangkao@redhat.com>
Subject: [PATCH v4 0/3] xfsprogs: consolidate stripe validation
Date: Wed, 7 Oct 2020 22:03:59 +0800 [thread overview]
Message-ID: <20201007140402.14295-1-hsiangkao@aol.com> (raw)
In-Reply-To: 20201007140402.14295-1-hsiangkao.ref@aol.com
From: Gao Xiang <hsiangkao@redhat.com>
Hi,
v3: https://lore.kernel.org/r/20200806130301.27937-1-hsiangkao@redhat.com
This is another approach suggested by Eric in the reply of v3
(if I understand correctly), which also attempts to use
i18n-enabled xfsprogs xfs_notice() to error out sanity check
failure suggested by Dave on IRC.
In addition, I manually ported [PATCH 2/3] to the kernel side
as well then fault injection with xfs_db and it seems work
as expected.
Thanks,
Gao Xiang
changes since v3:
- mainly follow Eric suggestion mentioned in the reply of v3,
e.g directly prints the error using xfs_notice/warn() and
return bool;
- with an exception that it doesn't need the unit of sunit/swidth
are in bytes if sectorsize is not specified, since the sanity
check logic condition only needs these are in the same unit,
so it saves calculation for these FSB / sector-based
representation.
Gao Xiang (3):
xfsprogs: allow i18n to xfs printk
xfs: introduce xfs_validate_stripe_factors()
xfsprogs: make use of xfs_validate_stripe_factors()
libxfs/libxfs_priv.h | 8 +++----
libxfs/xfs_sb.c | 54 +++++++++++++++++++++++++++++++++++---------
libxfs/xfs_sb.h | 3 +++
mkfs/xfs_mkfs.c | 23 ++++++-------------
4 files changed, 57 insertions(+), 31 deletions(-)
--
2.24.0
next parent reply other threads:[~2020-10-07 14:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201007140402.14295-1-hsiangkao.ref@aol.com>
2020-10-07 14:03 ` Gao Xiang [this message]
2020-10-07 14:04 ` [PATCH v4 1/3] xfsprogs: allow i18n to xfs printk Gao Xiang
2020-10-07 15:28 ` Darrick J. Wong
2020-10-09 1:01 ` Gao Xiang
2020-10-07 14:04 ` [PATCH v4 2/3] xfs: introduce xfs_validate_stripe_factors() Gao Xiang
2020-10-07 22:29 ` Darrick J. Wong
2020-10-09 0:54 ` Gao Xiang
2020-10-07 14:04 ` [PATCH v4 3/3] xfsprogs: make use of xfs_validate_stripe_factors() Gao Xiang
2020-10-07 22:30 ` Darrick J. Wong
2020-10-09 0:58 ` Gao Xiang
2020-10-09 13:02 ` Eric Sandeen
2020-10-09 13:50 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007140402.14295-1-hsiangkao@aol.com \
--to=hsiangkao@aol.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hsiangkao@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).