linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Brian Foster <bfoster@redhat.com>,
	Eric Sandeen <sandeen@redhat.com>,
	xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2] xfs_scrub: don't use statvfs to collect filesystem summary counts
Date: Thu, 15 Oct 2020 09:16:44 +0100	[thread overview]
Message-ID: <20201015081644.GA1882@infradead.org> (raw)
In-Reply-To: <20201009153741.GT6540@magnolia>

On Fri, Oct 09, 2020 at 08:37:41AM -0700, Darrick J. Wong wrote:
> > whereas the ioctl looks like it just reads
> > our internal counter (which IIRC is a subset of physically allocated
> > inode chunks). Do we care about that semantic here either way?
> 
> Nope.  The one caller that cares (scrub/phase7.c) only wants to know the
> number of inodes in use (f_free - f_files), which is unaffected by the
> logic in xfs_fs_statfs.
> 
> I suppose I could trim the parameter list even further to return only
> the file count...

Please do.  Or just kill the helper entirely and open code the trivial
ioctl call in the two callers.

  reply	other threads:[~2020-10-15  8:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 16:37 [PATCH v2] xfs_scrub: don't use statvfs to collect filesystem summary counts Darrick J. Wong
2020-10-09 11:18 ` Brian Foster
2020-10-09 11:32   ` Brian Foster
2020-10-09 15:37     ` Darrick J. Wong
2020-10-15  8:16       ` Christoph Hellwig [this message]
2020-10-12 19:29 ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201015081644.GA1882@infradead.org \
    --to=hch@infradead.org \
    --cc=bfoster@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).