From: Christoph Hellwig <hch@infradead.org>
To: xiakaixu1987@gmail.com
Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com,
Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH v5 3/3] xfs: directly return if the delta equal to zero
Date: Thu, 15 Oct 2020 09:25:20 +0100 [thread overview]
Message-ID: <20201015082520.GC3583@infradead.org> (raw)
In-Reply-To: <1602298461-32576-4-git-send-email-kaixuxia@tencent.com>
> + xfs_trans_mod_dquot(tp, dqp,
> + flags & XFS_QMOPT_RESBLK_MASK,
> + nblks);
> + xfs_trans_mod_dquot(tp, dqp,
> + XFS_TRANS_DQ_RES_INOS,
> + ninos);
This can be shortened to:
xfs_trans_mod_dquot(tp, dqp, flags & XFS_QMOPT_RESBLK_MASK,
nblk);
xfs_trans_mod_dquot(tp, dqp, XFS_TRANS_DQ_RES_INOS, ninos);
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-10-15 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 2:54 [PATCH v5 0/3] xfs: random fixes for disk quota xiakaixu1987
2020-10-10 2:54 ` [PATCH v5 1/3] xfs: delete duplicated tp->t_dqinfo null check and allocation xiakaixu1987
2020-10-15 8:22 ` Christoph Hellwig
2020-10-16 2:57 ` kaixuxia
2020-10-10 2:54 ` [PATCH v5 2/3] xfs: check tp->t_dqinfo value instead of the XFS_TRANS_DQ_DIRTY flag xiakaixu1987
2020-10-15 8:23 ` Christoph Hellwig
2020-10-10 2:54 ` [PATCH v5 3/3] xfs: directly return if the delta equal to zero xiakaixu1987
2020-10-15 8:25 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015082520.GC3583@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=kaixuxia@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).