From: Ira Weiny <ira.weiny@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Eric Sandeen <sandeen@redhat.com>,
Miklos Szeredi <mszeredi@redhat.com>,
David Howells <dhowells@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-man <linux-man@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Xiaoli Feng <xifeng@redhat.com>
Subject: Re: [PATCH 1/2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT
Date: Wed, 2 Dec 2020 18:45:04 -0800 [thread overview]
Message-ID: <20201203024504.GA1563847@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <CAHk-=wjiU5Fq7aG0-H6QN1ZsK-U3Hw1K310N2z_eCPPDTKeysA@mail.gmail.com>
On Wed, Dec 02, 2020 at 12:42:08PM -0800, Linus Torvalds wrote:
> On Tue, Dec 1, 2020 at 6:16 PM Ira Weiny <ira.weiny@intel.com> wrote:
> >
> > This will force a change to xfstests at a minimum. And I do know of users who
> > have been using this value. But I have gotten inquires about using the feature
> > so there are users out there.
>
> If it's only a few tests that fail, I wouldn't worry about it, and the
> tests should just be updated.
Done[1]
>
> But if there are real user concerns, we may need to have some kind of
> compat code. Because of the whole "no regressions" thing.
>
> What would the typical failure cases be in practice?
The failure will be a user not seeing their file operating in DAX mode when
they expect it to.
I discussed this with Dan Williams today. He and I agreed the flag is new
enough that we don't think users have any released code to the API just yet.
So I think we will be ok.
Also, after learning what the other flag was for I agree with Christoph that
the impact is going to be minimal since users are not typically operating on
the root inode.
So I think we are ok with just making the change and getting it into stable
quickly.
Thanks,
Ira
[1] https://lore.kernel.org/lkml/20201202214629.1563760-1-ira.weiny@intel.com/
next prev parent reply other threads:[~2020-12-03 2:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 16:54 [PATCH 0/2] statx: Fix DAX attribute collision and handling Eric Sandeen
2020-12-01 16:57 ` [PATCH 1/2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT Eric Sandeen
2020-12-01 17:32 ` Darrick J. Wong
2020-12-01 17:44 ` Eric Sandeen
2020-12-01 18:31 ` Andreas Dilger
2020-12-01 18:36 ` Eric Sandeen
2020-12-02 2:16 ` Ira Weiny
2020-12-02 20:42 ` Linus Torvalds
2020-12-03 2:45 ` Ira Weiny [this message]
2020-12-03 18:04 ` Linus Torvalds
2020-12-01 16:59 ` [PATCH 2/2] statx: move STATX_ATTR_DAX attribute handling to filesystems Eric Sandeen
2020-12-01 17:39 ` Darrick J. Wong
2020-12-01 17:53 ` Eric Sandeen
2020-12-01 20:52 ` Dave Chinner
2020-12-01 22:03 ` Eric Sandeen
2020-12-01 22:12 ` Linus Torvalds
2020-12-01 22:26 ` Eric Sandeen
2020-12-02 2:29 ` Ira Weiny
2020-12-02 8:03 ` Christoph Hellwig
2020-12-01 20:04 ` Linus Torvalds
2020-12-01 20:50 ` Eric Sandeen
2020-12-01 21:04 ` David Howells
2020-12-01 22:09 ` Linus Torvalds
2020-12-02 0:11 ` Eric Sandeen
2020-12-01 17:18 ` [PATCH 1/2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT David Howells
2020-12-01 17:20 ` [PATCH 2/2] statx: move STATX_ATTR_DAX attribute handling to filesystems David Howells
2020-12-01 17:28 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203024504.GA1563847@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=dhowells@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=sandeen@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=xifeng@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).