From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] [RFC] xfs: initialise attr fork on inode create
Date: Thu, 3 Dec 2020 08:40:12 +0000 [thread overview]
Message-ID: <20201203084012.GA32480@infradead.org> (raw)
In-Reply-To: <20201202232724.1730114-1-david@fromorbit.com>
This looks pretty sensible, and pretty simple. Why the RFC?
This looks good to me modulo a few tiny nitpicks below:
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index 1414ab79eacf..75b44b82ad1f 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -126,6 +126,7 @@ xfs_cleanup_inode(
> xfs_remove(XFS_I(dir), &teardown, XFS_I(inode));
> }
>
> +
> STATIC int
> xfs_generic_create(
> struct inode *dir,
Nit: this adds a spuurious empty line.
> @@ -161,7 +162,14 @@ xfs_generic_create(
> goto out_free_acl;
>
> if (!tmpfile) {
> - error = xfs_create(XFS_I(dir), &name, mode, rdev, &ip);
> + bool need_xattr = false;
> +
> + if ((IS_ENABLED(CONFIG_SECURITY) && dir->i_sb->s_security) ||
> + default_acl || acl)
> + need_xattr = true;
> +
> + error = xfs_create(XFS_I(dir), &name, mode, rdev,
> + need_xattr, &ip);
It might be wort to factor the condition into a little helper. Also
I think we also have security labels for O_TMPFILE inodes, so it might
be worth plugging into that path as well.
next prev parent reply other threads:[~2020-12-03 8:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 23:27 [PATCH] [RFC] xfs: initialise attr fork on inode create Dave Chinner
2020-12-03 8:40 ` Christoph Hellwig [this message]
2020-12-03 21:44 ` Dave Chinner
2020-12-04 7:54 ` Christoph Hellwig
2020-12-07 17:22 ` Casey Schaufler
2020-12-07 17:25 ` Christoph Hellwig
2020-12-07 20:49 ` Dave Chinner
2020-12-04 12:31 ` Brian Foster
2020-12-04 21:22 ` Dave Chinner
2020-12-05 11:34 ` Brian Foster
2020-12-06 23:33 ` Dave Chinner
2020-12-07 16:30 ` Brian Foster
2020-12-07 17:18 ` Darrick J. Wong
2020-12-07 17:12 ` Darrick J. Wong
2020-12-07 17:31 ` Christoph Hellwig
2020-12-07 20:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203084012.GA32480@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).