From: Gao Xiang <hsiangkao@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH v2 3/6] xfs: move on-disk inode allocation out of xfs_ialloc()
Date: Fri, 4 Dec 2020 08:58:00 +0800 [thread overview]
Message-ID: <20201204005800.GA1963435@xiangao.remote.csb> (raw)
In-Reply-To: <20201203203130.GB3913616@dread.disaster.area>
Hi Dave,
On Fri, Dec 04, 2020 at 07:31:30AM +1100, Dave Chinner wrote:
> On Fri, Dec 04, 2020 at 12:10:25AM +0800, Gao Xiang wrote:
...
> > - * directly to the superblock - and so have no parent.
> > + * Initialise a newly allocated inode and return the in-core inode to the
> > + * caller locked exclusively.
> > */
> > -static int
> > +static struct xfs_inode *
> > xfs_ialloc(
>
> Can we rename this xfs_dir_ialloc_init()?
>
> That way we keep everything in xfs_inode.c under the same namespace
> (xfs_dir_ialloc_*) and don't confuse it with functions in the
> xfs_ialloc_* namespace in fs/xfs/libxfs/xfs_ialloc*.c...
Ok, thanks for the suggestion! Let me revise it in the next version.
Thanks,
Gao Xiang
>
> Otherwise looks good.
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
>
next prev parent reply other threads:[~2020-12-04 0:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 16:10 [PATCH v2 0/6] xfs: some xfs_dialloc() cleanup Gao Xiang
2020-12-03 16:10 ` [PATCH v2 1/6] xfs: convert noroom, okalloc in xfs_dialloc() to bool Gao Xiang
2020-12-03 20:32 ` Dave Chinner
2020-12-03 16:10 ` [PATCH v2 2/6] xfs: introduce xfs_dialloc_roll() Gao Xiang
2020-12-03 19:20 ` Darrick J. Wong
2020-12-03 16:10 ` [PATCH v2 3/6] xfs: move on-disk inode allocation out of xfs_ialloc() Gao Xiang
2020-12-03 19:21 ` Darrick J. Wong
2020-12-03 20:31 ` Dave Chinner
2020-12-04 0:58 ` Gao Xiang [this message]
2020-12-03 16:10 ` [PATCH v2 4/6] xfs: move xfs_dialloc_roll() into xfs_dialloc() Gao Xiang
2020-12-03 19:25 ` Darrick J. Wong
2020-12-03 16:10 ` [PATCH v2 5/6] xfs: spilt xfs_dialloc() into 2 functions Gao Xiang
2020-12-03 19:29 ` Darrick J. Wong
2020-12-03 16:10 ` [PATCH v2 6/6] xfs: kill ialloced in xfs_dialloc() Gao Xiang
2020-12-03 19:08 ` Darrick J. Wong
2020-12-03 20:33 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204005800.GA1963435@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).