From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: move kernel-specific superblock validation out of libxfs
Date: Fri, 4 Dec 2020 13:12:06 -0800 [thread overview]
Message-ID: <20201204211206.GE106271@magnolia> (raw)
In-Reply-To: <d54542e0-728f-52b4-3762-c9353fcae8de@sandeen.net>
On Fri, Dec 04, 2020 at 02:35:45PM -0600, Eric Sandeen wrote:
> On 11/30/20 9:37 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > A couple of the superblock validation checks apply only to the kernel,
> > so move them to xfs_mount.c before we start changing sb_inprogress.
> > This also reduces the diff between kernel and userspace libxfs.
>
> My only complaint is that "xfs_sb_validate_mount" isn't really descriptive
> at all, and nobody reading the code or comments will know why we've chosen
> to move just these two checks out of the common validator...
>
> What does "compatible with this mount" mean?
Compatible with this implementation?
> Maybe just fess up in the comment, and say "these checks are different
> for kernel vs. userspace so we keep them over here" - and as for the
> function name, *shrug* not sure I have anything better...
_validate_implementation? I don't have a better suggestion either.
--D
> -Eric
>
next prev parent reply other threads:[~2020-12-04 21:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 3:37 [PATCH 0/3] xfs: add the ability to flag a fs for repair Darrick J. Wong
2020-12-01 3:37 ` [PATCH 1/3] xfs: move kernel-specific superblock validation out of libxfs Darrick J. Wong
2020-12-01 16:17 ` Brian Foster
2020-12-04 20:35 ` Eric Sandeen
2020-12-04 21:12 ` Darrick J. Wong [this message]
2020-12-04 21:46 ` Eric Sandeen
2020-12-04 23:02 ` Darrick J. Wong
2020-12-04 23:29 ` Dave Chinner
2020-12-01 3:37 ` [PATCH 2/3] xfs: define a new "needrepair" feature Darrick J. Wong
2020-12-01 16:18 ` Brian Foster
2020-12-01 16:25 ` Darrick J. Wong
2020-12-01 17:09 ` Brian Foster
2020-12-04 20:07 ` Eric Sandeen
2020-12-04 21:36 ` Darrick J. Wong
2020-12-01 3:37 ` [PATCH 3/3] xfs: enable the needsrepair feature Darrick J. Wong
2020-12-01 16:18 ` Brian Foster
2020-12-04 20:35 ` Eric Sandeen
2020-12-04 1:13 ` [PATCH 4/3] xfs_db: support the needsrepair feature flag in the version command Darrick J. Wong
2020-12-04 20:32 ` Eric Sandeen
2020-12-04 21:09 ` Darrick J. Wong
2020-12-04 21:16 ` Eric Sandeen
2020-12-04 1:13 ` [PATCH 5/3] xfs_repair: clear the needsrepair flag Darrick J. Wong
2020-12-06 23:09 [PATCH v2 0/3] xfs: add the ability to flag a fs for repair Darrick J. Wong
2020-12-06 23:09 ` [PATCH 1/3] xfs: move kernel-specific superblock validation out of libxfs Darrick J. Wong
2020-12-06 23:47 ` Dave Chinner
2020-12-07 17:17 ` Brian Foster
2020-12-09 17:08 ` Eric Sandeen
2020-12-09 18:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204211206.GE106271@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).