From: Christoph Hellwig <hch@lst.de>
To: Gao Xiang <hsiangkao@redhat.com>
Cc: linux-xfs@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
Eric Sandeen <sandeen@sandeen.net>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH v3 4/6] xfs: move xfs_dialloc_roll() into xfs_dialloc()
Date: Mon, 7 Dec 2020 14:53:36 +0100 [thread overview]
Message-ID: <20201207135336.GE29249@lst.de> (raw)
In-Reply-To: <20201207001533.2702719-5-hsiangkao@redhat.com>
>
> if (ialloced) {
> /*
> + * We successfully allocated some inodes, roll the
> + * transaction so they can allocate one of the free
> + * inodes we just prepared for them.
Maybe:
/*
* We successfully allocated space for an inode cluster
* in this AG. Roll the transaction so that we can
* allocate one of the new inodes.
*/
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-12-07 13:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 0:15 [PATCH v3 0/6] xfs: some xfs_dialloc() cleanup Gao Xiang
2020-12-07 0:15 ` [PATCH v3 1/6] xfs: convert noroom, okalloc in xfs_dialloc() to bool Gao Xiang
2020-12-07 0:15 ` [PATCH v3 2/6] xfs: introduce xfs_dialloc_roll() Gao Xiang
2020-12-07 13:43 ` Christoph Hellwig
2020-12-07 14:11 ` Gao Xiang
2020-12-07 0:15 ` [PATCH v3 3/6] xfs: move on-disk inode allocation out of xfs_ialloc() Gao Xiang
2020-12-07 13:49 ` Christoph Hellwig
2020-12-07 14:19 ` Gao Xiang
2020-12-07 14:21 ` Christoph Hellwig
2020-12-07 20:19 ` Dave Chinner
2020-12-07 16:59 ` Darrick J. Wong
2020-12-07 0:15 ` [PATCH v3 4/6] xfs: move xfs_dialloc_roll() into xfs_dialloc() Gao Xiang
2020-12-07 13:53 ` Christoph Hellwig [this message]
2020-12-07 14:20 ` Gao Xiang
2020-12-07 0:15 ` [PATCH v3 5/6] xfs: spilt xfs_dialloc() into 2 functions Gao Xiang
2020-12-07 13:56 ` Christoph Hellwig
2020-12-07 14:33 ` Gao Xiang
2020-12-07 16:38 ` Christoph Hellwig
2020-12-07 0:15 ` [PATCH v3 6/6] xfs: kill ialloced in xfs_dialloc() Gao Xiang
2020-12-07 13:57 ` Christoph Hellwig
2020-12-07 14:24 ` Gao Xiang
2020-12-07 20:23 ` Dave Chinner
2020-12-07 22:03 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207135336.GE29249@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=hsiangkao@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).