From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C743EC4332D for ; Thu, 14 Jan 2021 20:53:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD50E23A9A for ; Thu, 14 Jan 2021 20:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728564AbhANUwo (ORCPT ); Thu, 14 Jan 2021 15:52:44 -0500 Received: from mail110.syd.optusnet.com.au ([211.29.132.97]:43884 "EHLO mail110.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbhANUwn (ORCPT ); Thu, 14 Jan 2021 15:52:43 -0500 X-Greylist: delayed 489 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Jan 2021 15:52:40 EST Received: from dread.disaster.area (pa49-179-167-107.pa.nsw.optusnet.com.au [49.179.167.107]) by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 03E40105E38; Fri, 15 Jan 2021 07:51:54 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1l09b0-006Uat-5I; Fri, 15 Jan 2021 07:51:54 +1100 Date: Fri, 15 Jan 2021 07:51:54 +1100 From: Dave Chinner To: Christian Brauner Cc: Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Seth Forshee , =?iso-8859-1?Q?St=E9phane?= Graber , Linus Torvalds , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Serge Hallyn , Kees Cook , Todd Kjos , Paul Moore , Jonathan Corbet , containers@lists.linux-foundation.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v5 37/42] xfs: support idmapped mounts Message-ID: <20210114205154.GL331610@dread.disaster.area> References: <20210112220124.837960-1-christian.brauner@ubuntu.com> <20210112220124.837960-38-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112220124.837960-38-christian.brauner@ubuntu.com> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=Ubgvt5aN c=1 sm=1 tr=0 cx=a_idp_d a=+wqVUQIkAh0lLYI+QRsciw==:117 a=+wqVUQIkAh0lLYI+QRsciw==:17 a=kj9zAlcOel0A:10 a=EmqxpYm9HcoA:10 a=7-415B0cAAAA:8 a=44ec6t6cGFOkeLdKtF4A:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Jan 12, 2021 at 11:01:19PM +0100, Christian Brauner wrote: > From: Christoph Hellwig > > Enable idmapped mounts for xfs. This basically just means passing down > the user_namespace argument from the VFS methods down to where it is > passed to helper. > > Signed-off-by: Christoph Hellwig .... > @@ -654,6 +658,7 @@ xfs_vn_change_ok( > */ > static int > xfs_setattr_nonsize( > + struct user_namespace *mnt_userns, > struct xfs_inode *ip, > struct iattr *iattr) > { > @@ -813,7 +818,7 @@ xfs_setattr_nonsize( > * Posix ACL code seems to care about this issue either. > */ > if (mask & ATTR_MODE) { > - error = posix_acl_chmod(&init_user_ns, inode, inode->i_mode); > + error = posix_acl_chmod(mnt_userns, inode, inode->i_mode); > if (error) > return error; > } > @@ -868,7 +873,7 @@ xfs_setattr_size( > * Use the regular setattr path to update the timestamps. > */ > iattr->ia_valid &= ~ATTR_SIZE; > - return xfs_setattr_nonsize(ip, iattr); > + return xfs_setattr_nonsize(&init_user_ns, ip, iattr); Shouldn't that be passing mnt_userns? > } > > /* > @@ -1037,6 +1042,7 @@ xfs_setattr_size( > > int > xfs_vn_setattr_size( > + struct user_namespace *mnt_userns, > struct dentry *dentry, > struct iattr *iattr) > { > @@ -1045,7 +1051,7 @@ xfs_vn_setattr_size( > > trace_xfs_setattr(ip); > > - error = xfs_vn_change_ok(dentry, iattr); > + error = xfs_vn_change_ok(mnt_userns, dentry, iattr); > if (error) > return error; > return xfs_setattr_size(ip, iattr); And this passing mnt_userns down into xfs_setattr_size()? Seems like a bit of a landmine... Cheers, Dave. -- Dave Chinner david@fromorbit.com