From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v2 9/9] xfs: cover the log on freeze instead of cleaning it
Date: Thu, 21 Jan 2021 10:45:26 -0500 [thread overview]
Message-ID: <20210121154526.1852176-10-bfoster@redhat.com> (raw)
In-Reply-To: <20210121154526.1852176-1-bfoster@redhat.com>
Filesystem freeze cleans the log and immediately redirties it so log
recovery runs if a crash occurs after the filesystem is frozen. Now
that log quiesce covers the log, there is no need to clean the log and
redirty it to trigger log recovery because covering has the same
effect. Update xfs_fs_freeze() to quiesce (and thus cover) the log.
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index aedf622d221b..aed74a3fc787 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -889,8 +889,7 @@ xfs_fs_freeze(
flags = memalloc_nofs_save();
xfs_stop_block_reaping(mp);
xfs_save_resvblks(mp);
- xfs_log_clean(mp);
- ret = xfs_sync_sb(mp, true);
+ ret = xfs_log_quiesce(mp);
memalloc_nofs_restore(flags);
return ret;
}
--
2.26.2
next prev parent reply other threads:[~2021-01-21 15:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 15:45 [PATCH v2 0/9] xfs: rework log quiesce to cover the log Brian Foster
2021-01-21 15:45 ` [PATCH v2 1/9] xfs: sync lazy sb accounting on quiesce of read-only mounts Brian Foster
2021-01-21 15:45 ` [PATCH v2 2/9] xfs: lift writable fs check up into log worker task Brian Foster
2021-01-21 18:43 ` Darrick J. Wong
2021-01-21 15:45 ` [PATCH v2 3/9] xfs: separate log cleaning from log quiesce Brian Foster
2021-01-21 15:45 ` [PATCH v2 4/9] xfs: cover the log during " Brian Foster
2021-01-21 18:44 ` Darrick J. Wong
2021-01-22 3:16 ` Allison Henderson
2021-01-21 15:45 ` [PATCH v2 5/9] xfs: don't reset log idle state on covering checkpoints Brian Foster
2021-01-22 3:48 ` Allison Henderson
2021-01-21 15:45 ` [PATCH v2 6/9] xfs: fold sbcount quiesce logging into log covering Brian Foster
2021-01-22 3:13 ` Allison Henderson
2021-01-21 15:45 ` [PATCH v2 7/9] xfs: remove duplicate wq cancel and log force from attr quiesce Brian Foster
2021-01-22 3:13 ` Allison Henderson
2021-01-21 15:45 ` [PATCH v2 8/9] xfs: remove xfs_quiesce_attr() Brian Foster
2021-01-22 3:13 ` Allison Henderson
2021-01-21 15:45 ` Brian Foster [this message]
2021-01-22 3:13 ` [PATCH v2 9/9] xfs: cover the log on freeze instead of cleaning it Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121154526.1852176-10-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).