From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3257EC433DB for ; Fri, 22 Jan 2021 10:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 046122376F for ; Fri, 22 Jan 2021 10:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727891AbhAVKVw (ORCPT ); Fri, 22 Jan 2021 05:21:52 -0500 Received: from verein.lst.de ([213.95.11.211]:35935 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbhAVKV3 (ORCPT ); Fri, 22 Jan 2021 05:21:29 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 4F87368AFE; Fri, 22 Jan 2021 11:20:45 +0100 (CET) Date: Fri, 22 Jan 2021 11:20:45 +0100 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, avi@scylladb.com, Dave Chinner Subject: Re: [PATCH 11/11] xfs: reduce exclusive locking on unaligned dio Message-ID: <20210122102045.GA22568@lst.de> References: <20210121085906.322712-1-hch@lst.de> <20210121085906.322712-12-hch@lst.de> <20210121093549.GC4662@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210121093549.GC4662@dread.disaster.area> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Jan 21, 2021 at 08:35:49PM +1100, Dave Chinner wrote: > Why not use the ((offset | length) & mp->blockmask) form of > alignment checking here? Sure. I'ĺl switch to that. > Reviewed-by: Dave Chinner Given that the original patch and thus credit is yours this doesn't make sense to add, though.