From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, david@fromorbit.com
Subject: Re: [PATCH 1/3] xfs: increase the default parallelism levels of pwork clients
Date: Mon, 25 Jan 2021 15:07:16 -0800 [thread overview]
Message-ID: <20210125230716.GF7698@magnolia> (raw)
In-Reply-To: <20210124095717.GH670331@infradead.org>
On Sun, Jan 24, 2021 at 09:57:17AM +0000, Christoph Hellwig wrote:
> On Sat, Jan 23, 2021 at 10:53:08AM -0800, Darrick J. Wong wrote:
> > ASSERT(agno < mp->m_sb.sb_agcount);
> > ASSERT(!(flags & ~XFS_IWALK_FLAGS_ALL));
> >
> > - nr_threads = xfs_pwork_guess_datadev_parallelism(mp);
> > - error = xfs_pwork_init(mp, &pctl, xfs_iwalk_ag_work, "xfs_iwalk",
> > - nr_threads);
> > + error = xfs_pwork_init(mp, &pctl, xfs_iwalk_ag_work, "xfs_iwalk", 0);
>
>
> Why not drop the last argument to xfs_pwork_init as well? Also I don't
> think this makes sense as a standalone step without the changes in the
> next patch.
Ok, I'll combine these two.
--D
next prev parent reply other threads:[~2021-01-25 23:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 18:53 [PATCHSET 0/3] xfs: speed up parallel workqueues Darrick J. Wong
2021-01-23 18:53 ` [PATCH 1/3] xfs: increase the default parallelism levels of pwork clients Darrick J. Wong
2021-01-24 9:57 ` Christoph Hellwig
2021-01-25 23:07 ` Darrick J. Wong [this message]
2021-01-26 5:04 ` [PATCH v2.1 " Darrick J. Wong
2021-01-26 20:46 ` Dave Chinner
2021-01-26 23:32 ` Darrick J. Wong
2021-01-23 18:53 ` [PATCH 2/3] xfs: use unbounded workqueues for parallel work Darrick J. Wong
2021-01-24 9:51 ` Christoph Hellwig
2021-01-25 23:18 ` Darrick J. Wong
2021-01-23 18:53 ` [PATCH 3/3] xfs: set WQ_SYSFS on all workqueues Darrick J. Wong
2021-01-24 9:54 ` Christoph Hellwig
2021-01-25 23:30 ` Darrick J. Wong
2021-01-26 5:06 ` [PATCH 4/3] xfs: set WQ_SYSFS on all workqueues in debug mode Darrick J. Wong
2021-01-26 20:48 ` Dave Chinner
2021-01-27 17:03 ` Christoph Hellwig
2021-01-27 23:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125230716.GF7698@magnolia \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).