From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: restore speculative_cow_prealloc_lifetime sysctl
Date: Sat, 13 Feb 2021 09:46:56 +1100 [thread overview]
Message-ID: <20210212224656.GB4662@dread.disaster.area> (raw)
In-Reply-To: <20210212214802.GN7193@magnolia>
On Fri, Feb 12, 2021 at 01:48:02PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> In commit 9669f51de5c0 I tried to get rid of the undocumented cow gc
> lifetime knob. The knob's function was never documented and it now
> doesn't really have a function since eof and cow gc have been
> consolidated.
>
> Regrettably, xfs/231 relies on it and regresses on for-next. I did not
> succeed at getting far enough through fstests patch review for the fixup
> to land in time.
>
> Restore the sysctl knob, document what it did (does?), put it on the
> deprecation schedule, and rip out a redundant function.
>
> Fixes: 9669f51de5c0 ("xfs: consolidate the eofblocks and cowblocks workers")
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> v2: use printk_ratelimited
> ---
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2021-02-12 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 17:24 [PATCH] xfs: restore speculative_cow_prealloc_lifetime sysctl Darrick J. Wong
2021-02-12 21:21 ` Dave Chinner
2021-02-12 21:28 ` Darrick J. Wong
2021-02-12 21:48 ` [PATCH v2] " Darrick J. Wong
2021-02-12 22:46 ` Dave Chinner [this message]
2021-02-25 7:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212224656.GB4662@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).