Linux-XFS Archive on
 help / color / Atom feed
* [PATCH] xfs_admin: don't add '=1' when building repair command line for -O
@ 2021-03-02 17:27 Darrick J. Wong
  2021-03-02 18:13 ` Eric Sandeen
  0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2021-03-02 17:27 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs, Geert Hendrickx

From: Darrick J. Wong <>

Geert Hendrickx reported an inconsistency between the xfs_admin manpage
and its behavior -- the documentation says that users must provide the
status explicitly, but the script injects '=1' anyway.  While this seems
to work with the glibc getsubopt, it's a bit ugly and isn't consistent
with the docs.

So, get rid of that extra two bytes.

Reported-by: Geert Hendrickx <>
Signed-off-by: Darrick J. Wong <>
 db/ |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/db/ b/db/
index 7a467dbe..02f34b73 100755
--- a/db/
+++ b/db/
@@ -20,7 +20,7 @@ do
 	j)	DB_OPTS=$DB_OPTS" -c 'version log2'";;
 	l)	DB_OPTS=$DB_OPTS" -r -c label";;
 	L)	DB_OPTS=$DB_OPTS" -c 'label "$OPTARG"'";;
 	p)	DB_OPTS=$DB_OPTS" -c 'version projid32bit'";;
 	r)	REPAIR_DEV_OPTS=" -r '$OPTARG'";;
 	u)	DB_OPTS=$DB_OPTS" -r -c uuid";;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 17:27 [PATCH] xfs_admin: don't add '=1' when building repair command line for -O Darrick J. Wong
2021-03-02 18:13 ` Eric Sandeen

Linux-XFS Archive on

Archives are clonable:
	git clone --mirror linux-xfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-xfs linux-xfs/ \
	public-inbox-index linux-xfs

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone