From: Gao Xiang <hsiangkao@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [WIP] [RFC PATCH] xfs_growfs: allow shrinking unused space in the last AG
Date: Thu, 25 Mar 2021 08:44:13 +0800 [thread overview]
Message-ID: <20210325004413.GA2421109@xiangao.remote.csb> (raw)
In-Reply-To: <20210324173215.GU22100@magnolia>
On Wed, Mar 24, 2021 at 10:32:15AM -0700, Darrick J. Wong wrote:
> On Wed, Oct 28, 2020 at 07:40:10PM +0800, Gao Xiang wrote:
> > This allows shrinking operation can pass into kernel.
> >
> > Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
> > ---
> > preliminary version.
>
> ...which is going to need a manpage update:
>
> "-d | -D size
>
> "Specifies that the data section of the filesystem should be resized. If
> the -D size option is given, the data section is changed to that size,
> otherwise the data section is grown to the largest size possible with
> the -d option. The size is expressed in filesystem blocks. A filesystem
> with only 1 AG cannot be shrunk further, and a filesystem cannot be
> shrunk to the point where it would only have 1 AG."
Ah, ok, will update this. thanks for pointing out.
Thanks,
Gao Xiang
>
> --D
>
> >
> > growfs/xfs_growfs.c | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/growfs/xfs_growfs.c b/growfs/xfs_growfs.c
> > index a68b515d..d45ba703 100644
> > --- a/growfs/xfs_growfs.c
> > +++ b/growfs/xfs_growfs.c
> > @@ -246,12 +246,11 @@ main(int argc, char **argv)
> > error = 1;
> > }
> >
> > - if (!error && dsize < geo.datablocks) {
> > - fprintf(stderr, _("data size %lld too small,"
> > - " old size is %lld\n"),
> > + if (!error && dsize < geo.datablocks)
> > + fprintf(stderr,
> > +_("[EXPERIMENTAL] try to shrink unused space %lld, old size is %lld\n"),
> > (long long)dsize, (long long)geo.datablocks);
> > - error = 1;
> > - } else if (!error &&
> > + if (!error &&
> > dsize == geo.datablocks && maxpct == geo.imaxpct) {
> > if (dflag)
> > fprintf(stderr, _(
> > --
> > 2.18.1
> >
>
prev parent reply other threads:[~2021-03-25 0:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 11:40 [WIP] [RFC PATCH] xfs_growfs: allow shrinking unused space in the last AG Gao Xiang
2021-03-24 17:32 ` Darrick J. Wong
2021-03-25 0:44 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325004413.GA2421109@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).