From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C555C433E0 for ; Thu, 25 Mar 2021 09:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8EC961A0E for ; Thu, 25 Mar 2021 09:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229461AbhCYJBj (ORCPT ); Thu, 25 Mar 2021 05:01:39 -0400 Received: from verein.lst.de ([213.95.11.211]:40245 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbhCYJBP (ORCPT ); Thu, 25 Mar 2021 05:01:15 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id CA7B668BEB; Thu, 25 Mar 2021 10:01:12 +0100 (CET) Date: Thu, 25 Mar 2021 10:01:11 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH 13/18] xfs: use a union for i_cowextsize and i_flushiter Message-ID: <20210325090111.GA29134@lst.de> References: <20210324142129.1011766-1-hch@lst.de> <20210324142129.1011766-14-hch@lst.de> <20210325030628.GA4090233@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325030628.GA4090233@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Mar 24, 2021 at 08:06:28PM -0700, Darrick J. Wong wrote: > On Wed, Mar 24, 2021 at 03:21:24PM +0100, Christoph Hellwig wrote: > > The i_cowextsize field is only used for v3 inodes, and the i_flushiter > > field is only used for v1/v2 inodes. Use a union to pack the inode a > > littler better after adding a few missing guards around their usage. > > > > Signed-off-by: Christoph Hellwig > > Hmm, so this patch caused a regression on V4 filesystems xfs/051. It > looks like the flush iter gets set to zero and then log recovery forgets > to replay the inode(?) > > The following patch fixes it for me, FWIW... Indeed. I've folded something similar in.