From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-xfs-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2EE79C433E2
	for <linux-xfs@archiver.kernel.org>; Thu, 25 Mar 2021 15:50:28 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 0236061A27
	for <linux-xfs@archiver.kernel.org>; Thu, 25 Mar 2021 15:50:27 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230242AbhCYPty (ORCPT <rfc822;linux-xfs@archiver.kernel.org>);
        Thu, 25 Mar 2021 11:49:54 -0400
Received: from mail.kernel.org ([198.145.29.99]:48054 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S230182AbhCYPt1 (ORCPT <rfc822;linux-xfs@vger.kernel.org>);
        Thu, 25 Mar 2021 11:49:27 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id A75E461A11;
        Thu, 25 Mar 2021 15:49:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1616687366;
        bh=9Y0P6Gi89+OdshSj+J2GS/xAwGgpvzoIfrx7SyJprb8=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=kcJE1tP3g62weSnXg+8oIQ4X3F4CXNNF5bQ6qjSEq2wQx+AsKcr/Jw6CUVa3qOxiH
         NW8rr600FLQIX2RFiWmcgaFZRpB070Ar/vc9Kqzt9F4QgcRjWVcq4XhqAeGQ/rW+yf
         JZAfCGxGK4heoAvvW22bWQ/8ECTujb+aS/FfYmvLCaCBrAmCeT1b5obumw5GSVlJX3
         aMGsSIowXC/uBqqdO94+oyVn82jTqqDoR3sau4imJKsM4aWDckO4TEWGuD8TsUeud/
         d+4pkMSAV+hKt/iCLVCKBM6Y09POpQpSJmitXiUHHuv7ce5p2qUl3nUeb8XvtkNgT2
         BCX7Ahw95FvMA==
Date:   Thu, 25 Mar 2021 08:49:26 -0700
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     Christian Brauner <christian.brauner@ubuntu.com>
Cc:     Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org,
        linux-xfs@vger.kernel.org
Subject: Re: swapfile warnings
Message-ID: <20210325154926.GF4090233@magnolia>
References: <20210325154129.wf2qiwuybv7sad5j@wittgenstein>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210325154129.wf2qiwuybv7sad5j@wittgenstein>
Precedence: bulk
List-ID: <linux-xfs.vger.kernel.org>
X-Mailing-List: linux-xfs@vger.kernel.org

On Thu, Mar 25, 2021 at 04:41:29PM +0100, Christian Brauner wrote:
> Hey,
> 
> I've been running xfstests on a v5.12-rc3 kernel using a swapfile:
> 
> ubuntu@edfu|~
> > cat /etc/fstab
> # /etc/fstab: static file system information.
> #
> # Use 'blkid' to print the universally unique identifier for a
> # device; this may be used with UUID= as a more robust way to name devices
> # that works even if disks are added and removed. See fstab(5).
> #
> # <file system> <mount point>   <type>  <options>       <dump>  <pass>
> # / was on /dev/sdb1 during curtin installation
> /dev/disk/by-uuid/f2c4df25-b55c-4d1b-95fa-059f72ef86eb / ext4 defaults 0 0
> /swap.img       none    swap    sw      0       0
> 
> where my rootfs is ext4:
> 
> ubuntu@edfu|~
> > findmnt | grep -i ext4
> /                                     /dev/sdb1              ext4       rw,relatime
> 
> In addition to the /dev/sdb disk I have three other disks attached:
> 
> ubuntu@edfu|~
> > lsblk
> NAME   MAJ:MIN RM   SIZE RO TYPE MOUNTPOINT
> loop0    7:0    0  55.5M  1 loop /snap/core18/1988
> loop1    7:1    0  69.9M  1 loop /snap/lxd/19188
> loop2    7:2    0  70.4M  1 loop /snap/lxd/19647
> loop3    7:3    0  32.3M  1 loop /snap/snapd/11107
> loop4    7:4    0  32.3M  1 loop /snap/snapd/11402
> sda      8:0    0 931.5G  0 disk
> sdb      8:16   0 223.6G  0 disk
> └─sdb1   8:17   0 223.6G  0 part /
> sdc      8:32   0 279.5G  0 disk
> sdd      8:48   0 931.5G  0 disk
> 
> I'm using two of them /dev/sdc and /dev/sdb for xfstests:
> 
> ubuntu@edfu|~/src/git/xfstests
> > cat local.config
> # Ideally define at least these 4 to match your environment
> # The first 2 are required.
> # See README for other variables which can be set.
> #
> # Note: SCRATCH_DEV >will< get overwritten!
> 
> export FSTYP=xfs
> export TEST_DEV=/dev/sdc
> export TEST_DIR=/mnt/test
> export SCRATCH_DEV=/dev/sdd
> export SCRATCH_MNT=/mnt/scratch
> 
> when the system gets under load during test runs I assume it sometimes
> swaps and so sometimes I see the following messages pop up:
> 
> > sudo journalctl | grep -i swapon
> Mar 21 00:00:58 edfu kernel: swapon: file has shared extents
> Mar 21 02:25:52 edfu kernel: swapon: file has unallocated extents
> Mar 21 21:38:12 edfu kernel: swapon: file has shared extents
> Mar 22 00:16:03 edfu kernel: swapon: file has unallocated extents
> Mar 23 11:49:46 edfu kernel: swapon: file has shared extents
> Mar 23 12:34:38 edfu kernel: swapon: file has unallocated extents
> 
> I don't know enough about swapfiles to make any deep observations but I
> wonder what this can be caused by and whether this is something to worry
> about.

That's ... probably just fstests performing regression tests of the
swapfile activation code to make sure that we only ever feed the mm
file extents that are mapped and stable.

If you run only these tests:
generic/356 generic/357 generic/472 generic/493 generic/494 generic/495
generic/496 generic/497 generic/554 generic/569 generic/570

Do you get the kernel messages right away?  Those are the swapfile
stressors that I know about...

--D

> 
> Christian