From: "Darrick J. Wong" <djwong@kernel.org>
To: Anthony Iliopoulos <ailiop@suse.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: fix xfs_trans slab cache name
Date: Thu, 25 Mar 2021 11:47:30 -0700 [thread overview]
Message-ID: <20210325184730.GK4090233@magnolia> (raw)
In-Reply-To: <20210325164750.19599-1-ailiop@suse.com>
On Thu, Mar 25, 2021 at 05:47:50PM +0100, Anthony Iliopoulos wrote:
> Removal of kmem_zone_init wrappers accidentally changed a slab cache
> name from "xfs_trans" to "xf_trans". Fix this so that userspace
> consumers of /proc/slabinfo and /sys/kernel/slab can find it again.
>
> Fixes: b1231760e443 ("xfs: Remove slab init wrappers")
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
Heh, whoops.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 699c61637961..f816137ae976 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1905,7 +1905,7 @@ xfs_init_zones(void)
> if (!xfs_ifork_zone)
> goto out_destroy_da_state_zone;
>
> - xfs_trans_zone = kmem_cache_create("xf_trans",
> + xfs_trans_zone = kmem_cache_create("xfs_trans",
> sizeof(struct xfs_trans),
> 0, 0, NULL);
> if (!xfs_trans_zone)
> --
> 2.31.0
>
prev parent reply other threads:[~2021-03-25 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 16:47 [PATCH] xfs: fix xfs_trans slab cache name Anthony Iliopoulos
2021-03-25 18:47 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325184730.GK4090233@magnolia \
--to=djwong@kernel.org \
--cc=ailiop@suse.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).