From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 6/6] xfs: refactor per-AG inode tagging functions
Date: Fri, 26 Mar 2021 06:48:09 +0000 [thread overview]
Message-ID: <20210326064809.GG3421955@infradead.org> (raw)
In-Reply-To: <161671810634.621936.14531357513724748267.stgit@magnolia>
On Thu, Mar 25, 2021 at 05:21:46PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> In preparation for adding another incore inode tree tag, refactor the
> code that sets and clears tags from the per-AG inode tree and the tree
> of per-AG structures, and remove the open-coded versions used by the
> blockgc code.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/xfs_icache.c | 127 ++++++++++++++++++++++++---------------------------
> fs/xfs/xfs_icache.h | 2 -
> fs/xfs/xfs_super.c | 2 -
> fs/xfs/xfs_trace.h | 6 +-
> 4 files changed, 65 insertions(+), 72 deletions(-)
>
>
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 2b25fe679b0e..4c124bc98f39 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -29,6 +29,7 @@
> /* Forward declarations to reduce indirect calls */
> static int xfs_blockgc_scan_inode(struct xfs_inode *ip,
> struct xfs_eofblocks *eofb);
> +static inline void xfs_blockgc_queue(struct xfs_perag *pag);
> static bool xfs_reclaim_inode_grab(struct xfs_inode *ip);
> static void xfs_reclaim_inode(struct xfs_inode *ip, struct xfs_perag *pag);
>
> @@ -163,46 +164,78 @@ xfs_reclaim_work_queue(
> rcu_read_unlock();
> }
>
> +/* Set a tag on both the AG incore inode tree and the AG radix tree. */
> static void
> +xfs_perag_set_ici_tag(
> + struct xfs_perag *pag,
> + xfs_agino_t agino,
> + unsigned int tag)
Looking at the callers - I think the logic to lookup the pag and set the
inode flag should also go in here. Currently only xfs_inode_destroy
nests i_Flags log inside the pag_ici_lock, but I don't see how that
would harm the xfs_blockgc_set_iflag case. I suspect the unlocked
check in xfs_blockgc_set_iflag would harm in the reclaim case either.
> void
> +xfs_inode_destroy(
I find this new name a little confusing. What about
xfs_inode_mark_reclaimable?
But overall this new scheme looks nice to me.
next prev parent reply other threads:[~2021-03-26 6:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 0:21 [PATCHSET v3 0/6] xfs: clean up incore inode walk functions Darrick J. Wong
2021-03-26 0:21 ` [PATCH 1/6] xfs: use s_inodes in xfs_qm_dqrele_all_inodes Darrick J. Wong
2021-03-30 0:44 ` Dave Chinner
2021-03-30 2:36 ` Darrick J. Wong
2021-03-30 3:07 ` Dave Chinner
2021-03-30 4:06 ` Darrick J. Wong
2021-03-31 1:34 ` Dave Chinner
2021-03-26 0:21 ` [PATCH 2/6] xfs: remove iter_flags parameter from xfs_inode_walk_* Darrick J. Wong
2021-03-26 6:04 ` Christoph Hellwig
2021-03-26 0:21 ` [PATCH 3/6] xfs: remove indirect calls from xfs_inode_walk{,_ag} Darrick J. Wong
2021-03-26 6:08 ` Christoph Hellwig
2021-03-26 0:21 ` [PATCH 4/6] xfs: pass struct xfs_eofblocks to the inode scan callback Darrick J. Wong
2021-03-26 6:09 ` Christoph Hellwig
2021-03-26 0:21 ` [PATCH 5/6] xfs: merge xfs_reclaim_inodes_ag into xfs_inode_walk_ag Darrick J. Wong
2021-03-26 6:30 ` Christoph Hellwig
2021-03-26 16:07 ` Darrick J. Wong
2021-03-26 0:21 ` [PATCH 6/6] xfs: refactor per-AG inode tagging functions Darrick J. Wong
2021-03-26 6:48 ` Christoph Hellwig [this message]
2021-03-26 16:34 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326064809.GG3421955@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).