From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>
Subject: Re: attr fork related fstests failures on for-next
Date: Tue, 30 Mar 2021 08:06:11 +1100 [thread overview]
Message-ID: <20210329210611.GQ63242@dread.disaster.area> (raw)
In-Reply-To: <20210329204828.GP63242@dread.disaster.area>
On Tue, Mar 30, 2021 at 07:48:28AM +1100, Dave Chinner wrote:
> On Mon, Mar 29, 2021 at 11:31:20AM -0700, Darrick J. Wong wrote:
> > On Mon, Mar 29, 2021 at 02:16:04PM -0400, Brian Foster wrote:
> > > Hi,
> > >
> > > I'm seeing a couple different fstests failures on current for-next that
> > > appear to be associated with e6a688c33238 ("xfs: initialise attr fork on
> > > inode create"). The first is xfs_check complaining about sb versionnum
> > > bits on various tests:
> > >
> > > generic/003 16s ... _check_xfs_filesystem: filesystem on /dev/mapper/test-scratch is inconsistent (c)
> > > (see /root/xfstests-dev/results//generic/003.full for details)
> > > # cat results/generic/003.full
> > > ...
> > > _check_xfs_filesystem: filesystem on /dev/mapper/test-scratch is inconsistent (c)
> > > *** xfs_check output ***
> > > sb versionnum missing attr bit 10
> > > *** end xfs_check output
> >
> > FWIW I think this because that commit sets up an attr fork without
> > setting ATTR and ATTR2 in sb_version like xfs_bmap_add_attrfork does...
>
> Maybe, but mkfs.xfs sets ATTR2 by default and has for a long time.
> I'm not seeing this fail on either v4 or v5 filesystems on for-next
> with a current xfsprogs (5.11.0), so what environment is this test
> failing in?
>
> SECTION -- xfs
> FSTYP -- xfs (debug)
> PLATFORM -- Linux/x86_64 test3 5.12.0-rc5-dgc+ #3074 SMP
> PREEMPT Tue Mar 30 07:37:47 AEDT 2021
> MKFS_OPTIONS -- -f -m rmapbt=1,reflink=1 -i sparse=1 /dev/pmem1
> MOUNT_OPTIONS -- /dev/pmem1 /mnt/scratch
Ok, this regression test VM had selinux set to permissive so it
should have been using selinux. But at some time in the past,
"selinux=0" had been added to the kernel CLI, hence turning it off
and so not actually testing this path. I have a mix of selinux
enabled and disabled test VMs (because test matrix) and it looks
like this never made it to a VM that had selinux enabled...
Ok, I can reproduce it now, will fix.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2021-03-29 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 18:16 attr fork related fstests failures on for-next Brian Foster
2021-03-29 18:31 ` Darrick J. Wong
2021-03-29 20:48 ` Dave Chinner
2021-03-29 21:06 ` Dave Chinner [this message]
2021-03-29 21:07 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329210611.GQ63242@dread.disaster.area \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).