From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 05/20] xfs: remove the di_dmevmask and di_dmstate fields from struct xfs_icdinode
Date: Tue, 30 Mar 2021 19:33:29 +0200 [thread overview]
Message-ID: <20210330173329.GB14827@lst.de> (raw)
In-Reply-To: <20210330152811.GQ4090233@magnolia>
On Tue, Mar 30, 2021 at 08:28:11AM -0700, Darrick J. Wong wrote:
> Do you want to put dmevmask/dmstate preservation on the deprecated list
> too, seeing as the only (out of tree) user wrote in on the last
> submission to say that they're not supporting it past 2022 and have
> never supported mounting those XFSes with upstream kernels?
>
> Granted, the difficulty there is how do you deprecate something that
> isn't there? 8)
Yeah. I'm not sure what to really do about this. In practice I
suspect v5 file systems with these flags simply do not exist. The
cost to maintain the flag is pretty low, so I'm not sure the
deprecation is that important. I'd rather just reuse the flags
next time we add a new incompat feature that needs them, at which
point we have our normal feature mechanism take care of it.
next prev parent reply other threads:[~2021-03-30 17:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 5:38 xfs inode structure cleanups v4 Christoph Hellwig
2021-03-29 5:38 ` [PATCH 01/20] xfs: split xfs_imap_to_bp Christoph Hellwig
2021-03-29 5:38 ` [PATCH 02/20] xfs: consistently initialize di_flags2 Christoph Hellwig
2021-03-29 5:38 ` [PATCH 03/20] xfs: handle crtime more carefully in xfs_bulkstat_one_int Christoph Hellwig
2021-03-29 5:38 ` [PATCH 04/20] xfs: remove the unused xfs_icdinode_has_bigtime helper Christoph Hellwig
2021-03-29 5:38 ` [PATCH 05/20] xfs: remove the di_dmevmask and di_dmstate fields from struct xfs_icdinode Christoph Hellwig
2021-03-30 15:28 ` Darrick J. Wong
2021-03-30 17:33 ` Christoph Hellwig [this message]
2021-03-29 5:38 ` [PATCH 06/20] xfs: don't clear the "dinode core" in xfs_inode_alloc Christoph Hellwig
2021-03-29 5:38 ` [PATCH 07/20] xfs: move the di_projid field to struct xfs_inode Christoph Hellwig
2021-03-30 15:20 ` Darrick J. Wong
2021-03-29 5:38 ` [PATCH 08/20] xfs: move the di_size " Christoph Hellwig
2021-03-29 5:38 ` [PATCH 09/20] xfs: move the di_nblocks " Christoph Hellwig
2021-03-29 5:38 ` [PATCH 10/20] xfs: move the di_extsize " Christoph Hellwig
2021-03-29 5:38 ` [PATCH 11/20] xfs: move the di_cowextsize " Christoph Hellwig
2021-03-29 5:38 ` [PATCH 12/20] xfs: move the di_flushiter " Christoph Hellwig
2021-03-29 5:38 ` [PATCH 13/20] xfs: cleanup xfs_fill_fsxattr Christoph Hellwig
2021-03-29 5:38 ` [PATCH 14/20] xfs: use XFS_B_TO_FSB in xfs_ioctl_setattr Christoph Hellwig
2021-03-30 15:20 ` Darrick J. Wong
2021-03-29 5:38 ` [PATCH 15/20] xfs: use a union for i_cowextsize and i_flushiter Christoph Hellwig
2021-03-30 15:22 ` Darrick J. Wong
2021-03-29 5:38 ` [PATCH 16/20] xfs: move the di_forkoff field to struct xfs_inode Christoph Hellwig
2021-03-29 5:38 ` [PATCH 17/20] xfs: move the di_flags " Christoph Hellwig
2021-03-29 5:38 ` [PATCH 18/20] xfs: move the di_flags2 " Christoph Hellwig
2021-03-29 18:14 ` Darrick J. Wong
2021-03-29 5:38 ` [PATCH 19/20] xfs: move the di_crtime " Christoph Hellwig
2021-03-29 5:38 ` [PATCH 20/20] xfs: merge _xfs_dic2xflags into xfs_ip2xflags Christoph Hellwig
2021-03-30 15:25 ` Darrick J. Wong
2021-03-30 17:31 ` Christoph Hellwig
2021-03-30 18:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330173329.GB14827@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).