From: Christoph Hellwig <hch@infradead.org>
To: Chandan Babu R <chandanrlinux@gmail.com>
Cc: linux-xfs@vger.kernel.org, djwong@kernel.org
Subject: Re: [PATCH 2/2] xfs: Fix dax inode extent calculation when direct write is performed on an unwritten extent
Date: Fri, 2 Apr 2021 07:45:06 +0100 [thread overview]
Message-ID: <20210402064506.GB1739516@infradead.org> (raw)
In-Reply-To: <20210325140339.6603-2-chandanrlinux@gmail.com>
On Thu, Mar 25, 2021 at 07:33:39PM +0530, Chandan Babu R wrote:
> With dax enabled filesystems, a direct write operation into an existing
> unwritten extent results in xfs_iomap_write_direct() zero-ing and converting
> the extent into a normal extent before the actual data is copied from the
> userspace buffer.
>
> The inode extent count can increase by 2 if the extent range being written to
> maps to the middle of the existing unwritten extent range. Hence this commit
> uses XFS_IEXT_WRITE_UNWRITTEN_CNT as the extent count delta when such a write
> operation is being performed.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-04-02 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 14:03 [PATCH 1/2] xfs: Initialize xfs_alloc_arg->total correctly when allocating minlen extents Chandan Babu R
2021-03-25 14:03 ` [PATCH 2/2] xfs: Fix dax inode extent calculation when direct write is performed on an unwritten extent Chandan Babu R
2021-03-25 18:53 ` Darrick J. Wong
2021-04-02 6:45 ` Christoph Hellwig [this message]
2021-03-25 18:54 ` [PATCH 1/2] xfs: Initialize xfs_alloc_arg->total correctly when allocating minlen extents Darrick J. Wong
2021-04-02 6:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402064506.GB1739516@infradead.org \
--to=hch@infradead.org \
--cc=chandanrlinux@gmail.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).