From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 698E4C433B4 for ; Fri, 2 Apr 2021 06:49:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34DE661103 for ; Fri, 2 Apr 2021 06:49:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231207AbhDBGs7 (ORCPT ); Fri, 2 Apr 2021 02:48:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbhDBGs7 (ORCPT ); Fri, 2 Apr 2021 02:48:59 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBAB5C0613E6 for ; Thu, 1 Apr 2021 23:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M2rmiF1PXbh7VOlM+swBFn9SLo4OfoGQqWt9G752Eos=; b=kPKelNCXKziQVrevZfZLjKzNet DeNUoc4XXy0YLRh4YuGtdZlL5xoZL27I1XmJ3tCFcAGH1f0H4/5ayxD0wU9SkcQx2IbtExi0WLE4Y tSHvxIolLbs3EygDISd5M6fE4Pr7uoAL3+jsuunEYmF63TpiOXP6Y/fLE3CyYoi1Bli/KrZt62H6W RjiTLI6PAYAD1vP969CgcL6EEXSguyYZdhehOFIIRljTm8aHX/Oss9tH2e0xLFCHmd9LlwEQ+iNtr TieRg2xKjpzAn25FInBgF3cmwVSdrgW5lJnebUQsTqarH31F5BGaTAWMjmAibM98ndb1s3SJZycVL CSicwjNQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lSDbs-007Iue-SL; Fri, 02 Apr 2021 06:48:50 +0000 Date: Fri, 2 Apr 2021 07:48:48 +0100 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/4] xfs: eager inode attr fork init needs attr feature awareness Message-ID: <20210402064848.GE1739516@infradead.org> References: <20210330053059.1339949-1-david@fromorbit.com> <20210330053059.1339949-2-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330053059.1339949-2-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Mar 30, 2021 at 04:30:56PM +1100, Dave Chinner wrote: > From: Dave Chinner > > The pitfalls of regression testing on a machine without realising > that selinux was disabled. Only set the attr fork during inode > allocation if the attr feature bits are already set on the > superblock. > > Fixes: e6a688c33238 ("xfs: initialise attr fork on inode create") > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig