From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 3/9] xfs: expose sysfs knob to control inode inactivation delay
Date: Mon, 7 Jun 2021 19:02:53 -0700 [thread overview]
Message-ID: <20210608020253.GP2945738@locust> (raw)
In-Reply-To: <20210608010936.GH664593@dread.disaster.area>
On Tue, Jun 08, 2021 at 11:09:36AM +1000, Dave Chinner wrote:
> On Mon, Jun 07, 2021 at 03:25:10PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Allow administrators to control the length that we defer inode
> > inactivation. By default we'll set the delay to 2 seconds, as an
> > arbitrary choice between allowing for some batching of a deltree
> > operation, and not letting too many inodes pile up in memory.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> > Documentation/admin-guide/xfs.rst | 7 +++++++
> > fs/xfs/xfs_globals.c | 3 +++
> > fs/xfs/xfs_icache.c | 3 ++-
> > fs/xfs/xfs_linux.h | 1 +
> > fs/xfs/xfs_sysctl.c | 9 +++++++++
> > fs/xfs/xfs_sysctl.h | 1 +
> > 6 files changed, 23 insertions(+), 1 deletion(-)
> >
> >
> > diff --git a/Documentation/admin-guide/xfs.rst b/Documentation/admin-guide/xfs.rst
> > index f9b109bfc6a6..9dd62b155fda 100644
> > --- a/Documentation/admin-guide/xfs.rst
> > +++ b/Documentation/admin-guide/xfs.rst
> > @@ -277,6 +277,13 @@ The following sysctls are available for the XFS filesystem:
> > references and returns timed-out AGs back to the free stream
> > pool.
> >
> > + fs.xfs.inode_gc_delay
> > + (Units: centiseconds Min: 0 Default: 1 Max: 360000)
> > + The amount of time to delay cleanup work that happens after a file is
> > + closed by all programs. This involves clearing speculative
> > + preallocations from linked files and freeing unlinked files. A higher
> > + value here increases batching at a risk of background work storms.
>
> Can we make new timers use a sane unit of time like milliseconds?
Ok. Changing the name to inode_gc_delay_ms to make the units obvious to
userspace.
--D
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2021-06-08 2:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 22:24 [PATCHSET v6 0/9] xfs: deferred inode inactivation Darrick J. Wong
2021-06-07 22:24 ` [PATCH 1/9] xfs: refactor the inode recycling code Darrick J. Wong
2021-06-07 22:59 ` Dave Chinner
2021-06-08 0:14 ` Darrick J. Wong
2021-06-07 22:25 ` [PATCH 2/9] xfs: deferred inode inactivation Darrick J. Wong
2021-06-08 0:57 ` Dave Chinner
2021-06-08 4:40 ` Darrick J. Wong
2021-06-09 1:01 ` Dave Chinner
2021-06-09 1:28 ` Darrick J. Wong
2021-06-07 22:25 ` [PATCH 3/9] xfs: expose sysfs knob to control inode inactivation delay Darrick J. Wong
2021-06-08 1:09 ` Dave Chinner
2021-06-08 2:02 ` Darrick J. Wong [this message]
2021-06-07 22:25 ` [PATCH 4/9] xfs: force inode inactivation and retry fs writes when there isn't space Darrick J. Wong
2021-06-07 22:25 ` [PATCH 5/9] xfs: force inode garbage collection before fallocate when space is low Darrick J. Wong
2021-06-08 1:26 ` Dave Chinner
2021-06-08 11:48 ` Brian Foster
2021-06-08 15:32 ` Darrick J. Wong
2021-06-08 16:06 ` Brian Foster
2021-06-08 21:55 ` Dave Chinner
2021-06-09 0:25 ` Darrick J. Wong
2021-06-07 22:25 ` [PATCH 6/9] xfs: parallelize inode inactivation Darrick J. Wong
2021-06-07 22:25 ` [PATCH 7/9] xfs: create a polled function to force " Darrick J. Wong
2021-06-07 22:25 ` [PATCH 8/9] xfs: don't run speculative preallocation gc when fs is frozen Darrick J. Wong
2021-06-07 22:25 ` [PATCH 9/9] xfs: avoid buffer deadlocks when walking fs inodes Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2021-03-26 0:21 [PATCHSET v5 0/9] xfs: deferred inode inactivation Darrick J. Wong
2021-03-26 0:22 ` [PATCH 3/9] xfs: expose sysfs knob to control inode inactivation delay Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608020253.GP2945738@locust \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).