From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/6] xfs/304: don't turn quota accounting off
Date: Wed, 14 Jul 2021 16:29:12 -0700 [thread overview]
Message-ID: <20210714232912.GN22402@magnolia> (raw)
In-Reply-To: <20210712111146.82734-6-hch@lst.de>
On Mon, Jul 12, 2021 at 01:11:45PM +0200, Christoph Hellwig wrote:
> The test case tests just as much when just testing turning quota
> enforcement off, so switch it to that. This is in preparation for
> removing support to turn quota accounting off.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> tests/xfs/304 | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/xfs/304 b/tests/xfs/304
> index 2716ccd5..91fa5d97 100755
> --- a/tests/xfs/304
> +++ b/tests/xfs/304
> @@ -31,7 +31,7 @@ QUOTA_DIR=$SCRATCH_MNT/quota_dir
>
> mkdir -p $QUOTA_DIR
> echo "*** turn off group quotas"
> -xfs_quota -x -c 'off -g' $SCRATCH_MNT
> +xfs_quota -x -c 'disable -g' $SCRATCH_MNT
> rmdir $QUOTA_DIR
> echo "*** umount"
> _scratch_unmount
> @@ -39,7 +39,7 @@ _scratch_unmount
> _qmount
> mkdir -p $QUOTA_DIR
> echo "*** turn off project quotas"
> -xfs_quota -x -c 'off -p' $SCRATCH_MNT
> +xfs_quota -x -c 'disable -p' $SCRATCH_MNT
> rmdir $QUOTA_DIR
> echo "*** umount"
> _scratch_unmount
> @@ -47,7 +47,7 @@ _scratch_unmount
> _qmount
> mkdir -p $QUOTA_DIR
> echo "*** turn off group/project quotas"
> -xfs_quota -x -c 'off -gp' $SCRATCH_MNT
> +xfs_quota -x -c 'disable -gp' $SCRATCH_MNT
> rmdir $QUOTA_DIR
> echo "*** umount"
> _scratch_unmount
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-07-14 23:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 11:11 prepare for removing support to disable quota accounting Christoph Hellwig
2021-07-12 11:11 ` [PATCH 1/6] common/quota: allow removing quota options entirely in _qmount_option Christoph Hellwig
2021-07-14 23:35 ` Darrick J. Wong
2021-07-12 11:11 ` [PATCH 2/6] xfs/007: unmount after disabling quota Christoph Hellwig
2021-07-14 23:35 ` Darrick J. Wong
2021-07-12 11:11 ` [PATCH 3/6] xfs/106: don't test disabling quota accounting Christoph Hellwig
2021-07-14 23:37 ` Darrick J. Wong
2021-07-12 11:11 ` [PATCH 4/6] xfs/220: avoid failure when disabling quota accounting is not supported Christoph Hellwig
2021-07-14 23:30 ` Darrick J. Wong
2021-07-20 6:37 ` Christoph Hellwig
2021-07-12 11:11 ` [PATCH 5/6] xfs/304: don't turn quota accounting off Christoph Hellwig
2021-07-14 23:29 ` Darrick J. Wong [this message]
2021-07-12 11:11 ` [PATCH 6/6] xfs/305: " Christoph Hellwig
2021-07-14 23:28 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714232912.GN22402@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).