From: Christoph Hellwig <hch@lst.de>
To: linux-xfs@vger.kernel.org
Subject: don't allow disabling quota accounting on a mounted file system v2
Date: Thu, 22 Jul 2021 09:26:07 +0200 [thread overview]
Message-ID: <20210722072610.975281-1-hch@lst.de> (raw)
Hi all,
disabling quota accounting (vs just enforcement) on a running file system
is a fundamentally race and hard to get right operation. It also has
very little practical use.
Note that the quotaitem log recovery code is left for to make sure we
don't introduce inconsistent recovery states.
A series has been sent to make xfstests cope with this feature removal.
Changes since v1:
- fix a spelling mistake
Diffstat:
libxfs/xfs_quota_defs.h | 30 -----
libxfs/xfs_trans_resv.c | 30 -----
libxfs/xfs_trans_resv.h | 2
scrub/quota.c | 2
xfs_dquot.c | 3
xfs_dquot_item.c | 134 --------------------------
xfs_dquot_item.h | 17 ---
xfs_ioctl.c | 2
xfs_iops.c | 4
xfs_mount.c | 4
xfs_qm.c | 44 +++-----
xfs_qm.h | 3
xfs_qm_syscalls.c | 243 ++----------------------------------------------
xfs_quotaops.c | 30 +----
xfs_super.c | 51 ++++------
xfs_trans_dquot.c | 49 ---------
16 files changed, 77 insertions(+), 571 deletions(-)
next reply other threads:[~2021-07-22 7:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 7:26 Christoph Hellwig [this message]
2021-07-22 7:26 ` [PATCH 1/3] xfs: remove support for disabling quota accounting on a mounted file system Christoph Hellwig
2021-07-22 18:22 ` Darrick J. Wong
2021-07-22 19:03 ` Christoph Hellwig
2021-07-22 19:07 ` Darrick J. Wong
2021-07-23 5:05 ` Christoph Hellwig
2021-07-22 7:26 ` [PATCH 2/3] xfs: remove the flags argument to xfs_qm_dquot_walk Christoph Hellwig
2021-07-22 7:26 ` [PATCH 3/3] xfs: remove the active vs running quota differentiation Christoph Hellwig
2021-08-09 6:59 don't allow disabling quota accounting on a mounted file system v2 Christoph Hellwig
2021-08-09 16:13 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722072610.975281-1-hch@lst.de \
--to=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).