linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Pavel Reichl <preichl@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/8] xfsprogs: Rename platform.h -> common.h
Date: Mon, 2 Aug 2021 15:33:58 -0700	[thread overview]
Message-ID: <20210802223358.GK3601466@magnolia> (raw)
In-Reply-To: <20210802215024.949616-3-preichl@redhat.com>

On Mon, Aug 02, 2021 at 11:50:18PM +0200, Pavel Reichl wrote:
> No other platform then linux is supported so rename to something more
> common.
> ---
>  copy/xfs_copy.c                  | 2 +-
>  libfrog/{platform.h => common.h} | 0

This is confusing, we already have a scrub/common.h.  Renaming files
breaks git blame; why change them?

--D

>  libfrog/topology.c               | 2 +-
>  libxfs/init.c                    | 2 +-
>  libxfs/rdwr.c                    | 2 +-
>  repair/xfs_repair.c              | 2 +-
>  6 files changed, 5 insertions(+), 5 deletions(-)
>  rename libfrog/{platform.h => common.h} (100%)
> 
> diff --git a/copy/xfs_copy.c b/copy/xfs_copy.c
> index fc7d225f..c80b42d1 100644
> --- a/copy/xfs_copy.c
> +++ b/copy/xfs_copy.c
> @@ -12,7 +12,7 @@
>  #include <stdarg.h>
>  #include "xfs_copy.h"
>  #include "libxlog.h"
> -#include "libfrog/platform.h"
> +#include "libfrog/common.h"
>  
>  #define	rounddown(x, y)	(((x)/(y))*(y))
>  #define uuid_equal(s,d) (platform_uuid_compare((s),(d)) == 0)
> diff --git a/libfrog/platform.h b/libfrog/common.h
> similarity index 100%
> rename from libfrog/platform.h
> rename to libfrog/common.h
> diff --git a/libfrog/topology.c b/libfrog/topology.c
> index b1b470c9..b059829e 100644
> --- a/libfrog/topology.c
> +++ b/libfrog/topology.c
> @@ -11,7 +11,7 @@
>  #endif /* ENABLE_BLKID */
>  #include "xfs_multidisk.h"
>  #include "topology.h"
> -#include "platform.h"
> +#include "common.h"
>  
>  #define TERABYTES(count, blog)	((uint64_t)(count) << (40 - (blog)))
>  #define GIGABYTES(count, blog)	((uint64_t)(count) << (30 - (blog)))
> diff --git a/libxfs/init.c b/libxfs/init.c
> index 1ec83791..d1e87002 100644
> --- a/libxfs/init.c
> +++ b/libxfs/init.c
> @@ -21,7 +21,7 @@
>  #include "xfs_trans.h"
>  #include "xfs_rmap_btree.h"
>  #include "xfs_refcount_btree.h"
> -#include "libfrog/platform.h"
> +#include "libfrog/common.h"
>  
>  #include "libxfs.h"		/* for now */
>  
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index fd456d6b..f8e4cf0a 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -17,7 +17,7 @@
>  #include "xfs_inode_fork.h"
>  #include "xfs_inode.h"
>  #include "xfs_trans.h"
> -#include "libfrog/platform.h"
> +#include "libfrog/common.h"
>  
>  #include "libxfs.h"
>  
> diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c
> index 38406eea..af24b356 100644
> --- a/repair/xfs_repair.c
> +++ b/repair/xfs_repair.c
> @@ -23,7 +23,7 @@
>  #include "slab.h"
>  #include "rmap.h"
>  #include "libfrog/fsgeom.h"
> -#include "libfrog/platform.h"
> +#include "libfrog/common.h"
>  #include "bulkload.h"
>  #include "quotacheck.h"
>  
> -- 
> 2.31.1
> 

  reply	other threads:[~2021-08-02 22:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 21:50 [PATCH 0/8] xfsprogs: Drop the 'platform_' prefix Pavel Reichl
2021-08-02 21:50 ` [PATCH 1/8] xfsprogs: Rename platform_defs.h.in -> defs.h.in Pavel Reichl
2021-08-02 21:50 ` [PATCH 2/8] xfsprogs: Rename platform.h -> common.h Pavel Reichl
2021-08-02 22:33   ` Darrick J. Wong [this message]
2021-08-03 16:15     ` Pavel Reichl
2021-08-02 21:50 ` [PATCH 3/8] xfsprogs: remove platform_uuid_compare() Pavel Reichl
2021-08-02 22:35   ` Darrick J. Wong
2021-08-03 16:07     ` Pavel Reichl
2021-08-02 21:50 ` [PATCH 4/8] xfsprogs: remove platform_{test_xfs_fd,path,fstatfs} Pavel Reichl
2021-08-02 22:31   ` Darrick J. Wong
2021-08-02 21:50 ` [PATCH 5/8] xfsprogs: Rename platform_getoptreset -> getoptreset Pavel Reichl
2021-08-02 21:50 ` [PATCH 6/8] xfsprogs: remove all platform_ prefixes in linux.h Pavel Reichl
2021-08-02 21:50 ` [PATCH 7/8] xfsprogs: Remove platform_ prefixes in libfrog/common.h Pavel Reichl
2021-08-02 21:50 ` [PATCH 8/8] xfsprogs: remove platform_ from man xfsctl man page Pavel Reichl
2021-08-02 22:24 ` [PATCH 0/8] xfsprogs: Drop the 'platform_' prefix Darrick J. Wong
2021-08-23 22:45 ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802223358.GK3601466@magnolia \
    --to=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=preichl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).