From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC0DC432BE for ; Thu, 5 Aug 2021 05:38:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F25AA60F70 for ; Thu, 5 Aug 2021 05:38:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233428AbhHEFig (ORCPT ); Thu, 5 Aug 2021 01:38:36 -0400 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:42134 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230405AbhHEFig (ORCPT ); Thu, 5 Aug 2021 01:38:36 -0400 Received: from dread.disaster.area (pa49-195-182-146.pa.nsw.optusnet.com.au [49.195.182.146]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 31F871047C01; Thu, 5 Aug 2021 15:38:21 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1mBW5A-00EgeX-ES; Thu, 05 Aug 2021 15:38:16 +1000 Date: Thu, 5 Aug 2021 15:38:16 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH 10/14] xfs: flush inode inactivation work when compiling usage statistics Message-ID: <20210805053816.GA2757197@dread.disaster.area> References: <162812918259.2589546.16599271324044986858.stgit@magnolia> <162812923793.2589546.9838243331962795901.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162812923793.2589546.9838243331962795901.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=Tu+Yewfh c=1 sm=1 tr=0 a=QpfB3wCSrn/dqEBSktpwZQ==:117 a=QpfB3wCSrn/dqEBSktpwZQ==:17 a=kj9zAlcOel0A:10 a=MhDmnRu9jo8A:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=FpmZmofgXbK6OD1Gh5EA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Aug 04, 2021 at 07:07:17PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Users have come to expect that the space accounting information in > statfs and getquota reports are fairly accurate. Now that we inactivate > inodes from a background queue, these numbers can be thrown off by > whatever resources are singly-owned by the inodes in the queue. Flush > the pending inactivations when userspace asks for a space usage report. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/xfs_qm_syscalls.c | 8 ++++++++ > fs/xfs/xfs_super.c | 3 +++ > 2 files changed, 11 insertions(+) Makes sense. These aren't perf/latency sensitive operations, so waiting on completion of a flush shouldn't be a big deal. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com