From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0496EC4320A for ; Wed, 18 Aug 2021 06:54:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCD7F6108F for ; Wed, 18 Aug 2021 06:54:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238005AbhHRGyy (ORCPT ); Wed, 18 Aug 2021 02:54:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42317 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238538AbhHRGyx (ORCPT ); Wed, 18 Aug 2021 02:54:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629269657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kSyVRRLdTaR5BnmqQkrKDGZgg2FPj3zsseALNyKWYTc=; b=VI+0rK08WEMa0wxeoKCS/CVDX9HJZNfC2RQ0OB/79eQdCFEWmjKhFHu42ljJ2zzw8+3kUB KhHvt8lSIYNiDFh85YP6kIaOgg7qRzJNSIw0eIKkHzNvu9O+i/Gi2F5WZuQGNpMOmpYeUC XpvoAcUb5dIC/m8Mrn5DsVdmqafaNyI= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-439-i5-ylr4OOhqHN482mqVJOw-1; Wed, 18 Aug 2021 02:54:15 -0400 X-MC-Unique: i5-ylr4OOhqHN482mqVJOw-1 Received: by mail-pg1-f197.google.com with SMTP id v21-20020a63d5550000b029023c8042ce63so875338pgi.8 for ; Tue, 17 Aug 2021 23:54:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=kSyVRRLdTaR5BnmqQkrKDGZgg2FPj3zsseALNyKWYTc=; b=pm5ud3Pip30ov264XvIb4RuhhYEY1sJMw4QG7lzD/frvLdcbqb0folPnUbNcR2TTpm lwjbh6PMFPKMhO7LQsK/PvQuRXowKHdm18oGGOLuikQRl3rLPtTjEIX6tsnZ0pnhlJFL tmvf5Sn62BZfzwdQvQ5ogfYXyAXhqQL6BYfSf+a4Qz10ZI5KKrrfbh5H4VsDTadQAphr YV10Zc99BBE1uy3ILgn4Lnuubrudz7tHrS/+p8Z30ip3ze8lH+ve6bwBMUjLHKDaRvPJ xoDMxEn81quBflX6S+ZxonRHv5HTDtjT2A7weW8NIhclzicwS7zmfQu54Afn80+t68ay nr8Q== X-Gm-Message-State: AOAM5339l0YR8uukyy8aSRpdzOExPFbmc7y0jXtKCw4C8mKxLzHmxPTY hU707RIFNG+w8ztp9vuadYy/BgKyxM7/YKuacoNqw/+6BOvn9yuaruLdKJlt762Au8QfCpSOlgc imDZ5G8zIEJJTyp0D7meL X-Received: by 2002:a63:170d:: with SMTP id x13mr7232277pgl.216.1629269654769; Tue, 17 Aug 2021 23:54:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyz2KVAiFRNRxO4yKiokn0A7iKB9VpLE0b2C2xsw+YMJpFeaSPN96/U8+ygxA5gi8kYTORFmQ== X-Received: by 2002:a63:170d:: with SMTP id x13mr7232257pgl.216.1629269654413; Tue, 17 Aug 2021 23:54:14 -0700 (PDT) Received: from fedora ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id oj2sm3818685pjb.33.2021.08.17.23.54.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Aug 2021 23:54:14 -0700 (PDT) Date: Wed, 18 Aug 2021 15:06:54 +0800 From: Zorro Lang To: "Darrick J. Wong" Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me Subject: Re: [PATCH 2/2] generic: test shutdowns of a nested filesystem Message-ID: <20210818070654.hmhq7g5t4u3xueaj@fedora> Mail-Followup-To: "Darrick J. Wong" , guaneryu@gmail.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me References: <162924439425.779465.16029390956507261795.stgit@magnolia> <162924440518.779465.6907507760500586987.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162924440518.779465.6907507760500586987.stgit@magnolia> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Aug 17, 2021 at 04:53:25PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > generic/475, but we're running fsstress on a disk image inside the > scratch filesystem > > Signed-off-by: Darrick J. Wong > --- Good to me, thanks for this helpful test case. Just one question, is it better to use xfs_metadump with "-o" option by default? Reviewed-by: Zorro Lang > common/rc | 20 +++++++ > tests/generic/725 | 136 +++++++++++++++++++++++++++++++++++++++++++++++++ > tests/generic/725.out | 2 + > 3 files changed, 158 insertions(+) > create mode 100755 tests/generic/725 > create mode 100644 tests/generic/725.out > > > diff --git a/common/rc b/common/rc > index 84757fc1..473bfb0a 100644 > --- a/common/rc > +++ b/common/rc > @@ -631,6 +631,26 @@ _ext4_metadump() > $DUMP_COMPRESSOR -f "$dumpfile" &>> "$seqres.full" > } > > +# Capture the metadata of a filesystem in a dump file for offline analysis > +_metadump_dev() { > + local device="$1" > + local dumpfile="$2" > + local compressopt="$3" > + > + case "$FSTYP" in > + ext*) > + _ext4_metadump $device $dumpfile $compressopt > + ;; > + xfs) > + _xfs_metadump $dumpfile $device none $compressopt > + ;; > + *) > + echo "Don't know how to metadump $FSTYP" > + return 1 > + ;; > + esac > +} > + > _test_mkfs() > { > case $FSTYP in > diff --git a/tests/generic/725 b/tests/generic/725 > new file mode 100755 > index 00000000..ac008fdb > --- /dev/null > +++ b/tests/generic/725 > @@ -0,0 +1,136 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2021 Oracle, Inc. All Rights Reserved. > +# > +# FS QA Test No. 725 > +# > +# Test nested log recovery with repeated (simulated) disk failures. We kick > +# off fsstress on a loopback filesystem mounted on the scratch fs, then switch > +# out the underlying scratch device with dm-error to see what happens when the > +# disk goes down. Having taken down both fses in this manner, remount them and > +# repeat. This test simulates VM hosts crashing to try to shake out CoW bugs > +# in writeback on the host that cause VM guests to fail to recover. > +# > +. ./common/preamble > +_begin_fstest shutdown auto log metadata eio recoveryloop > + > +_cleanup() > +{ > + cd / > + $KILLALL_PROG -9 fsstress > /dev/null 2>&1 > + wait > + if [ -n "$loopmnt" ]; then > + $UMOUNT_PROG $loopmnt 2>/dev/null > + rm -r -f $loopmnt > + fi > + rm -f $tmp.* > + _dmerror_unmount > + _dmerror_cleanup > +} > + > +# Import common functions. > +. ./common/dmerror > +. ./common/reflink > + > +# Modify as appropriate. > +_supported_fs generic > + > +_require_scratch_reflink > +_require_cp_reflink > +_require_dm_target error > +_require_command "$KILLALL_PROG" "killall" > + > +echo "Silence is golden." > + > +_scratch_mkfs >> $seqres.full 2>&1 > +_require_metadata_journaling $SCRATCH_DEV > +_dmerror_init > +_dmerror_mount > + > +# Create a fs image consuming 1/3 of the scratch fs > +scratch_freesp_bytes=$(_get_available_space $SCRATCH_MNT) > +loopimg_bytes=$((scratch_freesp_bytes / 3)) > + > +loopimg=$SCRATCH_MNT/testfs > +truncate -s $loopimg_bytes $loopimg > +_mkfs_dev $loopimg > + > +loopmnt=$tmp.mount > +mkdir -p $loopmnt > + > +scratch_aliveflag=$tmp.runsnap > +snap_aliveflag=$tmp.snapping > + > +snap_loop_fs() { > + touch "$snap_aliveflag" > + while [ -e "$scratch_aliveflag" ]; do > + rm -f $loopimg.a > + _cp_reflink $loopimg $loopimg.a > + sleep 1 > + done > + rm -f "$snap_aliveflag" > +} > + > +fsstress=($FSSTRESS_PROG $FSSTRESS_AVOID -d "$loopmnt" -n 999999 -p "$((LOAD_FACTOR * 4))") > + > +for i in $(seq 1 $((25 * TIME_FACTOR)) ); do > + touch $scratch_aliveflag > + snap_loop_fs >> $seqres.full 2>&1 & > + > + if ! _mount $loopimg $loopmnt -o loop; then > + rm -f $scratch_aliveflag > + _metadump_dev $loopimg $seqres.loop.$i.md > + _fail "iteration $i loopimg mount failed" > + break > + fi > + > + ("${fsstress[@]}" >> $seqres.full &) > /dev/null 2>&1 > + > + # purposely include 0 second sleeps to test shutdown immediately after > + # recovery > + sleep $((RANDOM % (3 * TIME_FACTOR) )) > + rm -f $scratch_aliveflag > + > + # This test aims to simulate sudden disk failure, which means that we > + # do not want to quiesce the filesystem or otherwise give it a chance > + # to flush its logs. Therefore we want to call dmsetup with the > + # --nolockfs parameter; to make this happen we must call the load > + # error table helper *without* 'lockfs'. > + _dmerror_load_error_table > + > + ps -e | grep fsstress > /dev/null 2>&1 > + while [ $? -eq 0 ]; do > + $KILLALL_PROG -9 fsstress > /dev/null 2>&1 > + wait > /dev/null 2>&1 > + ps -e | grep fsstress > /dev/null 2>&1 > + done > + for ((i = 0; i < 10; i++)); do > + test -e "$snap_aliveflag" || break > + sleep 1 > + done > + > + # Mount again to replay log after loading working table, so we have a > + # consistent fs after test. > + $UMOUNT_PROG $loopmnt > + _dmerror_unmount || _fail "iteration $i scratch unmount failed" > + _dmerror_load_working_table > + if ! _dmerror_mount; then > + _metadump_dev $DMERROR_DEV $seqres.scratch.$i.md > + _fail "iteration $i scratch mount failed" > + fi > +done > + > +# Make sure the fs image file is ok > +if [ -f "$loopimg" ]; then > + if _mount $loopimg $loopmnt -o loop; then > + $UMOUNT_PROG $loopmnt &> /dev/null > + else > + _metadump_dev $DMERROR_DEV $seqres.scratch.final.md > + echo "final scratch mount failed" > + fi > + SCRATCH_RTDEV= SCRATCH_LOGDEV= _check_scratch_fs $loopimg > +fi > + > +# success, all done; let the test harness check the scratch fs > +status=0 > +exit > diff --git a/tests/generic/725.out b/tests/generic/725.out > new file mode 100644 > index 00000000..ed73a9fc > --- /dev/null > +++ b/tests/generic/725.out > @@ -0,0 +1,2 @@ > +QA output created by 725 > +Silence is golden. >