From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A42BC432BE for ; Thu, 19 Aug 2021 02:29:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 201A1610FE for ; Thu, 19 Aug 2021 02:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235700AbhHSCaN (ORCPT ); Wed, 18 Aug 2021 22:30:13 -0400 Received: from mail107.syd.optusnet.com.au ([211.29.132.53]:56537 "EHLO mail107.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235688AbhHSCaN (ORCPT ); Wed, 18 Aug 2021 22:30:13 -0400 Received: from dread.disaster.area (pa49-195-182-146.pa.nsw.optusnet.com.au [49.195.182.146]) by mail107.syd.optusnet.com.au (Postfix) with ESMTPS id 074CA1143BE3; Thu, 19 Aug 2021 12:29:34 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1mGXoA-002LsG-QB; Thu, 19 Aug 2021 12:29:30 +1000 Date: Thu, 19 Aug 2021 12:29:30 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 01/15] xfs: fix incorrect unit conversion in scrub tracepoint Message-ID: <20210819022930.GR3657114@dread.disaster.area> References: <162924373176.761813.10896002154570305865.stgit@magnolia> <162924373760.761813.14269643495581366455.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162924373760.761813.14269643495581366455.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=Tu+Yewfh c=1 sm=1 tr=0 a=QpfB3wCSrn/dqEBSktpwZQ==:117 a=QpfB3wCSrn/dqEBSktpwZQ==:17 a=kj9zAlcOel0A:10 a=MhDmnRu9jo8A:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=flfr51yFMHWp-Ax83cYA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Aug 17, 2021 at 04:42:17PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > XFS_DADDR_TO_FSB converts a raw disk address (in units of 512b blocks) > to a raw disk address (in units of fs blocks). Unfortunately, the > xchk_block_error_class tracepoints incorrectly uses this to decode > xfs_daddr_t into segmented AG number and AG block addresses. Use the > correct translation code. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/scrub/trace.h | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com