From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 207B0C4338F for ; Mon, 23 Aug 2021 22:08:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED92761076 for ; Mon, 23 Aug 2021 22:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233008AbhHWWJE (ORCPT ); Mon, 23 Aug 2021 18:09:04 -0400 Received: from mail106.syd.optusnet.com.au ([211.29.132.42]:49806 "EHLO mail106.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbhHWWJD (ORCPT ); Mon, 23 Aug 2021 18:09:03 -0400 Received: from dread.disaster.area (pa49-195-182-146.pa.nsw.optusnet.com.au [49.195.182.146]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id B612580D8FF; Tue, 24 Aug 2021 08:08:16 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1mII73-004BRh-0u; Tue, 24 Aug 2021 08:08:13 +1000 Date: Tue, 24 Aug 2021 08:08:13 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: Christoph Hellwig , xfs , linux-fsdevel Subject: Re: [PATCH] iomap: standardize tracepoint formatting and storage Message-ID: <20210823220813.GJ3657114@dread.disaster.area> References: <20210822023223.GY12640@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210822023223.GY12640@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=Tu+Yewfh c=1 sm=1 tr=0 a=QpfB3wCSrn/dqEBSktpwZQ==:117 a=QpfB3wCSrn/dqEBSktpwZQ==:17 a=kj9zAlcOel0A:10 a=MhDmnRu9jo8A:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=ufxPCYhPZurFViujDQIA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sat, Aug 21, 2021 at 07:32:23PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Print all the offset, pos, and length quantities in hexadecimal. While > we're at it, update the types of the tracepoint structure fields to > match the types of the values being recorded in them. > > Signed-off-by: Darrick J. Wong > --- > fs/iomap/trace.h | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) Looks good. That will help when mixed with XFS tracepoints :) Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com