From: Allison Henderson <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v24 00/11] Log Attribute Replay
Date: Tue, 24 Aug 2021 15:44:23 -0700 [thread overview]
Message-ID: <20210824224434.968720-1-allison.henderson@oracle.com> (raw)
Hi all,
This set is a subset of a larger series parent pointers. Delayed attributes allow
attribute operations (set and remove) to be logged and committed in the same
way that other delayed operations do. This allows more complex operations (like
parent pointers) to be broken up into multiple smaller transactions. To do
this, the existing attr operations must be modified to operate as a delayed
operation. This means that they cannot roll, commit, or finish transactions.
Instead, they return -EAGAIN to allow the calling function to handle the
transaction. In this series, we focus on only the delayed attribute portion.
We will introduce parent pointers in a later set.
The set as a whole is a bit much to digest at once, so I usually send out the
smaller sub series to reduce reviewer burn out. But the entire extended series
is visible through the included github links.
Updates since v23:
xfs: Return from xfs_attr_set_iter if there are no more rmtblks to process
Fixed xfs/125 fail
xfs: Capture buffers for delayed ops
NEW
xfs: Set up infrastructure for deferred attribute operations
Commit message updated with new name
Removed hasdelattr() from xfs_attri_validate
xfs: Implement attr logging and replay
Fixed xfs_sb_version_hasdelattr to use sb_features_log_incompat
Removed redundant flag set in xfs_trans_attr_finish_update
Renamed XFS_SB_FEAT_INCOMPAT_LOG_DELATTR to XFS_SB_FEAT_INCOMPAT_LOG_XATTRS
Renamed xfs_sb_version_hasdelattr sb_version_haslogxattrs
Removed unneeded xfs_qm_dqattach_locked in xfs_trans_attr_finish_update
Changed xfs_hasdelattr to sb_version_haslogxattrs in xfs_attr_create_intent
Simplified args pointer in xfs_attri_item_recover
Removed uneeded buffer rejoin logic
RFC xfs: Skip flip flags for delayed attrs
Fixed xfs/125 fail
xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred
added delayed sample to avoid potential race when enabling feature
moved warn_once to after error check
xfs: Remove unused xfs_attr_*_args
Removed local variable leaf_bp
xfs: Add log attribute error tag
Renamed error tag to ERRTAG_LARP
xfs: Add larp debug option
NEW
xfs: Merge xfs_delattr_context into xfs_attr_item
Rebase adjustments
xfs: Add helper function xfs_attr_leaf_addname
Rebase adjustments
This series can be viewed on github here:
https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_v24
As well as the extended delayed attribute and parent pointer series:
https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_v24_extended
And the test cases:
https://github.com/allisonhenderson/xfs_work/tree/pptr_xfstestsv4
In order to run the test cases, you will need have the corresponding xfsprogs
changes as well. Which can be found here:
https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v24
https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v24_extended
To run the xfs attributes tests run:
check -g attr
To run as delayed attributes run:
echo 1 > /sys/fs/xfs/debug/larp;
check -g attr
To run parent pointer tests:
check -g parent
I've also made the corresponding updates to the user space side as well, and ported anything
they need to seat correctly.
Questions, comment and feedback appreciated!
Allison
Allison Collins (1):
xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred
Allison Henderson (10):
xfs: Return from xfs_attr_set_iter if there are no more rmtblks to
process
xfs: Capture buffers for delayed ops
xfs: Set up infrastructure for log atrribute replay
xfs: Implement attr logging and replay
RFC xfs: Skip flip flags for delayed attrs
xfs: Remove unused xfs_attr_*_args
xfs: Add log attribute error tag
xfs: Add larp debug option
xfs: Merge xfs_delattr_context into xfs_attr_item
xfs: Add helper function xfs_attr_leaf_addname
fs/xfs/Makefile | 1 +
fs/xfs/libxfs/xfs_attr.c | 454 +++++++++---------
fs/xfs/libxfs/xfs_attr.h | 57 ++-
fs/xfs/libxfs/xfs_attr_leaf.c | 3 +-
fs/xfs/libxfs/xfs_attr_remote.c | 37 +-
fs/xfs/libxfs/xfs_attr_remote.h | 6 +-
fs/xfs/libxfs/xfs_defer.c | 8 +-
fs/xfs/libxfs/xfs_defer.h | 7 +-
fs/xfs/libxfs/xfs_errortag.h | 4 +-
fs/xfs/libxfs/xfs_format.h | 10 +-
fs/xfs/libxfs/xfs_log_format.h | 44 +-
fs/xfs/libxfs/xfs_log_recover.h | 2 +
fs/xfs/scrub/common.c | 2 +
fs/xfs/xfs_attr_item.c | 814 ++++++++++++++++++++++++++++++++
fs/xfs/xfs_attr_item.h | 52 ++
fs/xfs/xfs_attr_list.c | 1 +
fs/xfs/xfs_bmap_item.c | 2 +-
fs/xfs/xfs_buf.c | 1 +
fs/xfs/xfs_buf.h | 1 +
fs/xfs/xfs_error.c | 3 +
fs/xfs/xfs_extfree_item.c | 2 +-
fs/xfs/xfs_globals.c | 1 +
fs/xfs/xfs_ioctl32.c | 2 +
fs/xfs/xfs_iops.c | 2 +
fs/xfs/xfs_log.c | 45 ++
fs/xfs/xfs_log.h | 1 +
fs/xfs/xfs_log_recover.c | 9 +
fs/xfs/xfs_ondisk.h | 2 +
fs/xfs/xfs_refcount_item.c | 2 +-
fs/xfs/xfs_rmap_item.c | 2 +-
fs/xfs/xfs_sysctl.h | 1 +
fs/xfs/xfs_sysfs.c | 24 +
fs/xfs/xfs_trace.h | 1 +
33 files changed, 1333 insertions(+), 270 deletions(-)
create mode 100644 fs/xfs/xfs_attr_item.c
create mode 100644 fs/xfs/xfs_attr_item.h
--
2.25.1
next reply other threads:[~2021-08-24 22:44 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 22:44 Allison Henderson [this message]
2021-08-24 22:44 ` [PATCH v24 01/11] xfs: Return from xfs_attr_set_iter if there are no more rmtblks to process Allison Henderson
2021-08-24 22:44 ` [PATCH v24 02/11] xfs: Capture buffers for delayed ops Allison Henderson
2021-08-27 11:33 ` Chandan Babu R
2021-08-31 18:03 ` Allison Henderson
2021-08-30 17:44 ` Darrick J. Wong
2021-08-31 17:50 ` Allison Henderson
2021-09-18 0:02 ` Darrick J. Wong
2021-08-24 22:44 ` [PATCH v24 03/11] xfs: Set up infrastructure for log atrribute replay Allison Henderson
2021-08-27 14:17 ` Chandan Babu R
2021-08-31 18:03 ` Allison Henderson
2021-08-31 0:48 ` Dave Chinner
2021-08-31 19:03 ` Allison Henderson
2021-08-31 21:52 ` Dave Chinner
2021-09-01 5:34 ` Allison Henderson
2021-08-24 22:44 ` [PATCH v24 04/11] xfs: Implement attr logging and replay Allison Henderson
2021-08-30 7:47 ` Chandan Babu R
2021-08-31 18:11 ` Allison Henderson
2021-08-24 22:44 ` [PATCH v24 05/11] RFC xfs: Skip flip flags for delayed attrs Allison Henderson
2021-08-30 10:15 ` Chandan Babu R
2021-08-31 18:11 ` Allison Henderson
2021-08-24 22:44 ` [PATCH v24 06/11] xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Henderson
2021-08-30 10:27 ` Chandan Babu R
2021-08-31 18:12 ` Allison Henderson
2021-09-01 3:47 ` Dave Chinner
2021-09-01 5:34 ` Allison Henderson
2021-08-24 22:44 ` [PATCH v24 07/11] xfs: Remove unused xfs_attr_*_args Allison Henderson
2021-08-24 22:44 ` [PATCH v24 08/11] xfs: Add log attribute error tag Allison Henderson
2021-08-24 22:44 ` [PATCH v24 09/11] xfs: Add larp debug option Allison Henderson
2021-08-30 12:03 ` Chandan Babu R
2021-08-31 18:12 ` Allison Henderson
2021-08-24 22:44 ` [PATCH v24 10/11] xfs: Merge xfs_delattr_context into xfs_attr_item Allison Henderson
2021-08-24 22:44 ` [PATCH v24 11/11] xfs: Add helper function xfs_attr_leaf_addname Allison Henderson
2021-08-30 14:17 ` Chandan Babu R
2021-08-31 18:13 ` Allison Henderson
2021-08-31 0:20 ` [PATCH v24 00/11] Log Attribute Replay Dave Chinner
2021-08-31 18:27 ` Allison Henderson
2021-09-01 6:29 ` Dave Chinner
2021-09-01 7:30 ` [PATCH 0/5] xfs: various logged attribute fixes Dave Chinner
2021-09-01 7:30 ` [PATCH 1/5] xfs: fix fallthrough annotations in xfs_attr_set_iter() Dave Chinner
2021-09-01 7:30 ` [PATCH 2/5] xfs: fix flags passed to kvmalloc() by xfs_attri_init() Dave Chinner
2021-09-01 7:30 ` [PATCH 3/5] xfs: hide log iovec alignment constraints Dave Chinner
2021-09-01 7:30 ` [PATCH 4/5] xfs: fix attribute log iovec sizing Dave Chinner
2021-09-01 7:30 ` [PATCH 5/5] [RFC] xfs: don't commit the first deferred transaction without intents Dave Chinner
2021-09-01 21:43 ` [PATCH 0/5] xfs: various logged attribute fixes Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824224434.968720-1-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).