linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Catherine Hoang <catherine.hoang@oracle.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 1/1] xfstests: Add Log Attribute Replay test
Date: Wed, 25 Aug 2021 15:28:07 -0700	[thread overview]
Message-ID: <20210825222807.GG12640@magnolia> (raw)
In-Reply-To: <20210825195144.2283-2-catherine.hoang@oracle.com>

On Wed, Aug 25, 2021 at 12:51:44PM -0700, Catherine Hoang wrote:
> From: Allison Henderson <allison.henderson@oracle.com>
> 
> This patch adds a test to exercise the log attribute error
> inject and log replay.  Attributes are added in increaseing
> sizes up to 64k, and the error inject is used to replay them
> from the log
> 
> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>

Yay, [your] first post! :D

> ---
>  tests/xfs/540     |  96 ++++++++++++++++++++++++++++++++++
>  tests/xfs/540.out | 130 ++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 226 insertions(+)
>  create mode 100755 tests/xfs/540
>  create mode 100644 tests/xfs/540.out
> 
> diff --git a/tests/xfs/540 b/tests/xfs/540
> new file mode 100755
> index 00000000..3b05b38b
> --- /dev/null
> +++ b/tests/xfs/540
> @@ -0,0 +1,96 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2021, Oracle and/or its affiliates.  All Rights Reserved.
> +#
> +# FS QA Test 540
> +#
> +# Log attribute replay test
> +#
> +. ./common/preamble
> +_begin_fstest auto quick attr
> +
> +# get standard environment, filters and checks
> +. ./common/filter
> +. ./common/attr
> +. ./common/inject
> +
> +_cleanup()
> +{
> +	echo "*** unmount"
> +	_scratch_unmount 2>/dev/null
> +	rm -f $tmp.*
> +	echo 0 > /sys/fs/xfs/debug/larp
> +}
> +
> +_test_attr_replay()
> +{
> +	attr_name=$1
> +	attr_value=$2
> +	touch $testfile.1
> +
> +	echo "Inject error"
> +	_scratch_inject_error "larp"
> +
> +	echo "Set attribute"
> +	echo "$attr_value" | ${ATTR_PROG} -s "$attr_name" $testfile.1 | \
> +			    _filter_scratch
> +
> +	echo "FS should be shut down, touch will fail"
> +	touch $testfile.1
> +
> +	echo "Remount to replay log"
> +	_scratch_inject_logprint >> $seqres.full
> +
> +	echo "FS should be online, touch should succeed"
> +	touch $testfile.1
> +
> +	echo "Verify attr recovery"
> +	_getfattr --absolute-names $testfile.1 | _filter_scratch

Shouldn't we check the value of the extended attrs too?

> +}
> +
> +
> +# real QA test starts here
> +_supported_fs xfs
> +
> +_require_scratch
> +_require_attrs
> +_require_xfs_io_error_injection "larp"
> +_require_xfs_sysfs debug/larp
> +
> +# turn on log attributes
> +echo 1 > /sys/fs/xfs/debug/larp
> +
> +rm -f $seqres.full

No need to do this anymore; _begin_fstest takes care of this now.

> +_scratch_unmount >/dev/null 2>&1
> +
> +#attributes of increaseing sizes
> +attr16="0123456789ABCDEFG"

"attr16" is seventeen bytes long.

> +attr64="$attr16$attr16$attr16$attr16"
> +attr256="$attr64$attr64$attr64$attr64"
> +attr1k="$attr256$attr256$attr256$attr256"
> +attr4k="$attr1k$attr1k$attr1k$attr1k"
> +attr8k="$attr4k$attr4k$attr4k$attr4k"

This is 17k long...

> +attr32k="$attr8k$attr8k$attr8k$attr8k"

...which makes this 68k long...

> +attr64k="$attr32k$attr32k"

...and this 136K long?

I'm curious, what are the contents of user.attr_name8?

OH, I see, attr clamps the value length to 64k, so I guess the oversize
buffers don't matter.

--D

> +
> +echo "*** mkfs"
> +_scratch_mkfs_xfs >/dev/null
> +
> +echo "*** mount FS"
> +_scratch_mount
> +
> +testfile=$SCRATCH_MNT/testfile
> +echo "*** make test file 1"
> +
> +_test_attr_replay "attr_name1" $attr16
> +_test_attr_replay "attr_name2" $attr64
> +_test_attr_replay "attr_name3" $attr256
> +_test_attr_replay "attr_name4" $attr1k
> +_test_attr_replay "attr_name5" $attr4k
> +_test_attr_replay "attr_name6" $attr8k
> +_test_attr_replay "attr_name7" $attr32k
> +_test_attr_replay "attr_name8" $attr64k
> +
> +echo "*** done"
> +status=0
> +exit
> diff --git a/tests/xfs/540.out b/tests/xfs/540.out
> new file mode 100644
> index 00000000..c1b178a0
> --- /dev/null
> +++ b/tests/xfs/540.out
> @@ -0,0 +1,130 @@
> +QA output created by 540
> +*** mkfs
> +*** mount FS
> +*** make test file 1
> +Inject error
> +Set attribute
> +attr_set: Input/output error
> +Could not set "attr_name1" for /mnt/scratch/testfile.1
> +FS should be shut down, touch will fail
> +touch: cannot touch '/mnt/scratch/testfile.1': Input/output error

The error messages need to be filtered too, because SCRATCH_MNT is
definitely not /mnt/scratch here. ;)

--D

> +Remount to replay log
> +FS should be online, touch should succeed
> +Verify attr recovery
> +# file: SCRATCH_MNT/testfile.1
> +user.attr_name1
> +
> +Inject error
> +Set attribute
> +attr_set: Input/output error
> +Could not set "attr_name2" for /mnt/scratch/testfile.1
> +FS should be shut down, touch will fail
> +touch: cannot touch '/mnt/scratch/testfile.1': Input/output error
> +Remount to replay log
> +FS should be online, touch should succeed
> +Verify attr recovery
> +# file: SCRATCH_MNT/testfile.1
> +user.attr_name1
> +user.attr_name2
> +
> +Inject error
> +Set attribute
> +attr_set: Input/output error
> +Could not set "attr_name3" for /mnt/scratch/testfile.1
> +FS should be shut down, touch will fail
> +touch: cannot touch '/mnt/scratch/testfile.1': Input/output error
> +Remount to replay log
> +FS should be online, touch should succeed
> +Verify attr recovery
> +# file: SCRATCH_MNT/testfile.1
> +user.attr_name1
> +user.attr_name2
> +user.attr_name3
> +
> +Inject error
> +Set attribute
> +attr_set: Input/output error
> +Could not set "attr_name4" for /mnt/scratch/testfile.1
> +FS should be shut down, touch will fail
> +touch: cannot touch '/mnt/scratch/testfile.1': Input/output error
> +Remount to replay log
> +FS should be online, touch should succeed
> +Verify attr recovery
> +# file: SCRATCH_MNT/testfile.1
> +user.attr_name1
> +user.attr_name2
> +user.attr_name3
> +user.attr_name4
> +
> +Inject error
> +Set attribute
> +attr_set: Input/output error
> +Could not set "attr_name5" for /mnt/scratch/testfile.1
> +FS should be shut down, touch will fail
> +touch: cannot touch '/mnt/scratch/testfile.1': Input/output error
> +Remount to replay log
> +FS should be online, touch should succeed
> +Verify attr recovery
> +# file: SCRATCH_MNT/testfile.1
> +user.attr_name1
> +user.attr_name2
> +user.attr_name3
> +user.attr_name4
> +user.attr_name5
> +
> +Inject error
> +Set attribute
> +attr_set: Input/output error
> +Could not set "attr_name6" for /mnt/scratch/testfile.1
> +FS should be shut down, touch will fail
> +touch: cannot touch '/mnt/scratch/testfile.1': Input/output error
> +Remount to replay log
> +FS should be online, touch should succeed
> +Verify attr recovery
> +# file: SCRATCH_MNT/testfile.1
> +user.attr_name1
> +user.attr_name2
> +user.attr_name3
> +user.attr_name4
> +user.attr_name5
> +user.attr_name6
> +
> +Inject error
> +Set attribute
> +attr_set: Input/output error
> +Could not set "attr_name7" for /mnt/scratch/testfile.1
> +FS should be shut down, touch will fail
> +touch: cannot touch '/mnt/scratch/testfile.1': Input/output error
> +Remount to replay log
> +FS should be online, touch should succeed
> +Verify attr recovery
> +# file: SCRATCH_MNT/testfile.1
> +user.attr_name1
> +user.attr_name2
> +user.attr_name3
> +user.attr_name4
> +user.attr_name5
> +user.attr_name6
> +user.attr_name7
> +
> +Inject error
> +Set attribute
> +attr_set: Input/output error
> +Could not set "attr_name8" for /mnt/scratch/testfile.1
> +FS should be shut down, touch will fail
> +touch: cannot touch '/mnt/scratch/testfile.1': Input/output error
> +Remount to replay log
> +FS should be online, touch should succeed
> +Verify attr recovery
> +# file: SCRATCH_MNT/testfile.1
> +user.attr_name1
> +user.attr_name2
> +user.attr_name3
> +user.attr_name4
> +user.attr_name5
> +user.attr_name6
> +user.attr_name7
> +user.attr_name8
> +
> +*** done
> +*** unmount
> -- 
> 2.25.1
> 

  reply	other threads:[~2021-08-25 22:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 19:51 [PATCH v4 0/1] Log Attribute Replay Test Catherine Hoang
2021-08-25 19:51 ` [PATCH 1/1] xfstests: Add Log Attribute Replay test Catherine Hoang
2021-08-25 22:28   ` Darrick J. Wong [this message]
2021-08-26  0:58     ` Allison Henderson
2021-08-26  1:02       ` Darrick J. Wong
2021-08-26  1:05         ` Allison Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210825222807.GG12640@magnolia \
    --to=djwong@kernel.org \
    --cc=catherine.hoang@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).