linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Eric Sandeen <esandeen@redhat.com>
Cc: xfs <linux-xfs@vger.kernel.org>, Bill O'Donnell <bodonnel@redhat.com>
Subject: Re: [PATCH] mkfs.xfs.8: clarify DAX-vs-reflink restrictions in the mkfs.xfs man page
Date: Fri, 27 Aug 2021 08:49:05 -0700	[thread overview]
Message-ID: <20210827154905.GP12640@magnolia> (raw)
In-Reply-To: <59ebcf23-9e32-e219-ef8b-9aa7ab2444c2@redhat.com>

On Fri, Aug 27, 2021 at 10:39:18AM -0500, Eric Sandeen wrote:
> Now that we have the tristate dax mount options, it is possible
> to enable DAX mode for non-reflinked files on a reflink-capable
> filesystem.  Clarify this in the mkfs.xfs manpage.
> 
> Reported-by: Bill O'Donnell <bodonnel@redhat.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
> index a7f70285..84ac50e8 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -316,12 +316,20 @@ option set. When the option
>  is used, the reference count btree feature is not supported and reflink is
>  disabled.
>  .IP
> -Note: the filesystem DAX mount option (
> +Note: the filesystem-wide DAX mount options (
>  .B \-o dax
> -) is incompatible with
> -reflink-enabled XFS filesystems.  To use filesystem DAX with XFS, specify the
> +and
> +.B \-o dax=always
> +) are incompatible with
> +reflink-enabled XFS filesystems.  To use filesystem-wide DAX with XFS, specify the
>  .B \-m reflink=0
>  option to mkfs.xfs to disable the reflink feature.
> +Alternatey, use the

"Alternately..."

> +.B \-o dax=inode
> +mount option to selectively enable DAX mode on non-reflinked files.

/me wonders if this is dangerously close to wading into the muck that is
"Use dax=inode or even no dax option at all, then make sure nobody
shares your file's data blocks to set the DAX fsxattr flag on the file,
and /then/ you can have DAX."

<shrug> But the only blocker I can see is the misspelling above.

--D

> +See
> +.BR xfs (5)
> +for more information.
>  .RE
>  .PP
>  .PD 0
> 

  parent reply	other threads:[~2021-08-27 15:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 15:39 Eric Sandeen
2021-08-27 15:46 ` Bill O'Donnell
2021-08-27 15:47   ` Eric Sandeen
2021-08-27 15:49 ` Darrick J. Wong [this message]
2021-08-27 16:23   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210827154905.GP12640@magnolia \
    --to=djwong@kernel.org \
    --cc=bodonnel@redhat.com \
    --cc=esandeen@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    --subject='Re: [PATCH] mkfs.xfs.8: clarify DAX-vs-reflink restrictions in the mkfs.xfs man page' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).