linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Eryu Guan <guaneryu@gmail.com>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	fstests <fstests@vger.kernel.org>, Eryu Guan <guan@eryu.me>
Subject: Re: [PATCH 9/9] new: don't allow new tests in group 'other'
Date: Fri, 17 Sep 2021 09:00:00 -0700	[thread overview]
Message-ID: <20210917160000.GA10224@magnolia> (raw)
In-Reply-To: <CAOQ4uxiXFw9t61S3J3MPULqrS9RvGEUPQf3Eq54P9qtjL8zMcw@mail.gmail.com>

On Fri, Sep 17, 2021 at 05:31:25AM +0300, Amir Goldstein wrote:
> On Fri, Sep 17, 2021 at 1:53 AM Darrick J. Wong <djwong@kernel.org> wrote:
> >
> > On Thu, Sep 16, 2021 at 09:40:54AM +0300, Amir Goldstein wrote:
> > > On Thu, Sep 16, 2021 at 2:43 AM Darrick J. Wong <djwong@kernel.org> wrote:
> > > >
> > > > From: Darrick J. Wong <djwong@kernel.org>
> > > >
> > > > The 'other' group is vaguely defined at best -- other than what?  It's
> > > > not clear what tests belong in this group, and it has become a dumping
> > > > ground for random stuff that are classified in other groups.  Don't let
> > > > people create new other group tests.
> > > >
> > > > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > > > ---
> > > >  new |    7 +++++--
> > > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > >
> > > >
> > > > diff --git a/new b/new
> > > > index 6b7dc5d4..5cf96c50 100755
> > > > --- a/new
> > > > +++ b/new
> > > > @@ -96,9 +96,9 @@ then
> > > >
> > > >      while true
> > > >      do
> > > > -       echo -n "Add to group(s) [other] (separate by space, ? for list): "
> > > > +       echo -n "Add to group(s) [auto] (separate by space, ? for list): "
> > > >         read ans
> > > > -       [ -z "$ans" ] && ans=other
> > > > +       [ -z "$ans" ] && ans=auto
> > > >         if [ "X$ans" = "X?" ]
> > > >         then
> > > >             echo $(group_names)
> > > > @@ -109,6 +109,9 @@ then
> > > >                 echo "Invalid characters in group(s): $inval"
> > > >                 echo "Only lower cases, digits and underscore are allowed in groups, separated by space"
> > > >                 continue
> > > > +           elif echo "$ans" | grep -q -w "other"; then
> > > > +               echo "Do not add more tests to group \"other\"."
> > > > +               continue
> > >
> > > Should we also filter out "other" from group_names(), so it is not listed
> > > for "?"?
> >
> > No; there are drawbacks to that, as you point out below.
> >
> > > With this patch, "other" does not emit a warning when passed in as a script
> > > command line argument.
> >
> > Done.
> >
> > > If we filter "other" from group_names(), then the warning in "expert mode"
> > > will be a bit confusing (group "other" not defined in documentation).
> >
> > I will filter it out in the specific case case that the interactive user
> > specified "?" to list the groups.
> >
> > > Also, it is not clear to me if this is intentional behavior that interactive
> > > mode allows non-dcumented groups (with valid chars validation) and
> > > expert mode does not allow non-documented groups?
> >
> > Probably not.
> >
> > > It may be simpler to use the same helper in both modes (is_group_valid)
> > > to emit the correct warning and either proceed (expert mode) or get
> > > back to prompt (interactive mode).
> >
> > This is getting farther afield from where I wanted this thing to go.
> > Very well, I'll split the ./new cleanups into its own series, but TBH
> > I've gotten tired of people asking for more and more cleanups out of me.
> >
> 
> Fair enough.
> TBH I just wanted to point out the inconsistencies that I noticed.
> I don't really mind if they are fixed.
> I should have been more clear about this point.

Oh.  Well thank you for reviewing this series and the ./new cleanups. :)

--D

> Thanks,
> Amir.

      reply	other threads:[~2021-09-17 16:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 23:42 [PATCHSET v3 0/9] fstests: document all test groups Darrick J. Wong
2021-09-15 23:42 ` [PATCH 1/9] ceph: re-tag copy_file_range as being in the copy_range group Darrick J. Wong
2021-09-16  5:51   ` Amir Goldstein
2021-09-15 23:42 ` [PATCH 2/9] xfs: move reflink tests into the clone group Darrick J. Wong
2021-09-16  5:51   ` Amir Goldstein
2021-09-15 23:42 ` [PATCH 3/9] xfs: fix incorrect fuzz test group name Darrick J. Wong
2021-09-16  5:52   ` Amir Goldstein
2021-09-15 23:42 ` [PATCH 4/9] btrfs: fix incorrect subvolume " Darrick J. Wong
2021-09-16  5:52   ` Amir Goldstein
2021-09-15 23:43 ` [PATCH 5/9] generic/631: change this test to use the 'whiteout' group Darrick J. Wong
2021-09-16  5:53   ` Amir Goldstein
2021-09-15 23:43 ` [PATCH 6/9] tools: make sure that test groups are described in the documentation Darrick J. Wong
2021-09-16  5:58   ` Amir Goldstein
2021-09-15 23:43 ` [PATCH 7/9] tools: add missing license tags to my scripts Darrick J. Wong
2021-09-16  6:06   ` Amir Goldstein
2021-09-16 21:44     ` Darrick J. Wong
2021-09-15 23:43 ` [PATCH 8/9] new: only allow documented test group names Darrick J. Wong
2021-09-16  6:10   ` Amir Goldstein
2021-09-15 23:43 ` [PATCH 9/9] new: don't allow new tests in group 'other' Darrick J. Wong
2021-09-16  6:40   ` Amir Goldstein
2021-09-16 22:53     ` Darrick J. Wong
2021-09-17  2:31       ` Amir Goldstein
2021-09-17 16:00         ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210917160000.GA10224@magnolia \
    --to=djwong@kernel.org \
    --cc=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    --subject='Re: [PATCH 9/9] new: don'\''t allow new tests in group '\''other'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).