From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C94C433EF for ; Tue, 12 Oct 2021 20:43:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7EBB60E0C for ; Tue, 12 Oct 2021 20:43:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234822AbhJLUpv (ORCPT ); Tue, 12 Oct 2021 16:45:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:58830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234757AbhJLUps (ORCPT ); Tue, 12 Oct 2021 16:45:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CA12260E09; Tue, 12 Oct 2021 20:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634071425; bh=q61LoQrLGHHMBvmawEYfkt6DnUrNORR1prK1fiM18ZA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uEThPiosyyrbJ4oy20wf2VLQNoPPVJxrr7w8jRKgrJSKn2ukj1kohMQza/+0d2pO6 yRlD2jC0/EsF1SWAMF48Ki40jtsW7eaR636VJgs0TZx2XM9ppxGfdvjPJ+WX9I0hkX Xrl9rq7ZnGE0t7KObzY2eQXdnfvyvIgJrMI8WsnbEgYh0DOSokYebdUXO9iCTiZo1h 8rD2jFMIJiQois0naFz2COeKuhTPyem/pK5xhXlMqJixUPECLB1P5smrct/KJxbCYT pNrCAC3uZzAhusWCSxT8zpVXHk8teiGxxkqt7mgQ74BqK7N2NVtg2gVWvlfQJ2l/Rd rGwbXgqgNuHsA== Date: Tue, 12 Oct 2021 13:43:45 -0700 From: "Darrick J. Wong" To: David Rientjes Cc: Rustam Kovhaev , Vlastimil Babka , Dave Chinner , linux-xfs@vger.kernel.org, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, Al Viro , dvyukov@google.com Subject: Re: [PATCH] xfs: use kmem_cache_free() for kmem_cache objects Message-ID: <20211012204345.GQ24307@magnolia> References: <20210929212347.1139666-1-rkovhaev@gmail.com> <20210930044202.GP2361455@dread.disaster.area> <17f537b3-e2eb-5d0a-1465-20f3d3c960e2@suse.cz> <1e0df91-556e-cee5-76f7-285d28fe31@google.com> <20211012204320.GP24307@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211012204320.GP24307@magnolia> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Oct 12, 2021 at 01:43:20PM -0700, Darrick J. Wong wrote: > On Sun, Oct 03, 2021 at 06:07:20PM -0700, David Rientjes wrote: > > On Thu, 30 Sep 2021, Rustam Kovhaev wrote: > > > > > > >> I think it's fair if something like XFS (not meant for tiny systems AFAIK?) > > > > >> excludes SLOB (meant for tiny systems). Clearly nobody tried to use these > > > > >> two together last 5 years anyway. > > > > > > > > > > +1 for adding Kconfig option, it seems like some things are not meant to > > > > > be together. > > > > > > > > But if we patch SLOB, we won't need it. > > > > > > OK, so we consider XFS on SLOB a supported configuration that might be > > > used and should be tested. > > > I'll look into maybe adding a config with CONFIG_SLOB and CONFIG_XFS_FS > > > to syzbot. > > > > > > It seems that we need to patch SLOB anyway, because any other code can > > > hit the very same issue. > > > > > > > It's probably best to introduce both (SLOB fix and Kconfig change for > > XFS), at least in the interim because the combo of XFS and SLOB could be > > broken in other ways. If syzbot doesn't complain with a patched kernel to > > allow SLOB to be used with XFS, then we could potentially allow them to be > > used together. > > > > (I'm not sure that this freeing issue is the *only* thing that is broken, > > nor that we have sufficient information to make that determination right > > now..) > > I audited the entire xfs (kernel) codebase and didn't find any other > usage errors. Thanks for the patch; I'll apply it to for-next. Also, the obligatory Reviewed-by: Darrick J. Wong --D > > --D