From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D552EC433F5 for ; Wed, 13 Oct 2021 05:34:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0ABA60FDC for ; Wed, 13 Oct 2021 05:34:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237729AbhJMFgx (ORCPT ); Wed, 13 Oct 2021 01:36:53 -0400 Received: from mail106.syd.optusnet.com.au ([211.29.132.42]:60918 "EHLO mail106.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237413AbhJMFgw (ORCPT ); Wed, 13 Oct 2021 01:36:52 -0400 Received: from dread.disaster.area (pa49-195-238-16.pa.nsw.optusnet.com.au [49.195.238.16]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id F0D38862048; Wed, 13 Oct 2021 16:34:48 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1maWue-005ens-68; Wed, 13 Oct 2021 16:34:48 +1100 Date: Wed, 13 Oct 2021 16:34:48 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: Chandan Babu R , Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH 07/15] xfs: refactor btree cursor allocation function Message-ID: <20211013053448.GZ2361455@dread.disaster.area> References: <163408155346.4151249.8364703447365270670.stgit@magnolia> <163408159230.4151249.14190118477095749260.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163408159230.4151249.14190118477095749260.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=epq8cqlX c=1 sm=1 tr=0 ts=61666ff9 a=DzKKRZjfViQTE5W6EVc0VA==:117 a=DzKKRZjfViQTE5W6EVc0VA==:17 a=kj9zAlcOel0A:10 a=8gfv0ekSlNoA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=HtCAKnzXIEwdfWwX6ZkA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Oct 12, 2021 at 04:33:12PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Refactor btree allocation to a common helper. > > Signed-off-by: Darrick J. Wong > Reviewed-by: Chandan Babu R > Reviewed-by: Christoph Hellwig > --- > fs/xfs/libxfs/xfs_alloc_btree.c | 6 +----- > fs/xfs/libxfs/xfs_bmap_btree.c | 6 +----- > fs/xfs/libxfs/xfs_btree.h | 16 ++++++++++++++++ > fs/xfs/libxfs/xfs_ialloc_btree.c | 5 +---- > fs/xfs/libxfs/xfs_refcount_btree.c | 5 +---- > fs/xfs/libxfs/xfs_rmap_btree.c | 5 +---- > 6 files changed, 21 insertions(+), 22 deletions(-) LGTM Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com